pantsbuild / pants / 5890
0%
main: 93%

LAST BUILD BRANCH: add/port-target-adaptor-and-source-block
DEFAULT BRANCH: main
Ran
Jobs 10
Files 343
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5890

push

travis-ci

mateor 
Integrate the Android SDK, android-library

This is the 2nd part of splitting up #2040. This follows up
on #2467 (adding unpack_libraries task and android_library).
This adds the google and android m2 repos from the SDK into
ivysettings.xml.

AndroidLibraries are unpacked once per artifact in UnpackLibraries.
The unpack .class files are packed into the android_binary's
classes.dex file. The android_library BUILD files allow for
include/exclude patterns, those patterns are filtered against
during the repack in DxCompile. This allows us several advantages:

  * each artifact is unpacked only once, no matter how many
    dependees or include patterns
  * therefore each class file has a static path, so duplicate
    class files (allowed in the build but illegal to pass to
    dx tool) are easily detected
  * Version conflicts are detected by class name(which is how it
    is done within the dx tool) and can raise a useful exception.

Processing the resources in AaptGen is moved off of the
codegen backend. The gentarget for AaptGen is the
AndroidBinary. Each android_library in the transitive
closure needs to be compiled against the binary's target_sdk.
Libraries are passed to the aapt tool once for every SDK
version they support.

This also adds lots of testing for big parts of the android
pipeline and a couple of new example projects to show the
new functionality.

Problems/Followups

* Duplicated code in UnpackJars and UnpackLibraries, including
  fingerprint handling. Pulling up an Unpack base class or refactor
  to FileUtil or something (this includes Fingerprint strategy)
* No invalidation framework for aapt_gen yet. It doesn't currently
  distinguish between libraries that need to be processed by
  multiple SDKs.

References #1390
References #10

Testing Done:
Travis passed

Bugs closed: 1866

Reviewed at https://rbcommons.com/s/twitter/r/2528/

15038 of 20481 relevant lines covered (73.42%)

1.38 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5890.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 5890.1
2 5890.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
69.02
 Travis Job 5890.2
3 5890.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
68.98
 Travis Job 5890.3
4 5890.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 5890.4
5 5890.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 5890.5
6 5890.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 5890.6
7 5890.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 5890.7
8 5890.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 5890.8
9 5890.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 5890.9
10 5890.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 5890.10
Source Files on build 5890
Detailed source file information is not available for this build.