johnbywater / eventsourcing / 2884
100%
master: 100%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 3
Files 106
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2884

push

travis-ci

johnbywater 
Improved record manager test cases, and added missing things.

Basically, I was thinking about using the 'set_notification_ids'
feature of application classes more, so that notifications
can be put into shared memory without needing to query the
database to get the notification IDs, and felt like the
testing of the "insert values" mode needed to be covered
better, in particular covered by the record manager tests
rather than only exercised by the application test cases.
In adding base test cases for these things, I was able to
test the record managers in a standard way, and then it
made sense to implement previously missing support for
these aspects in some record managers, and also improve
the tests so that now I feel more confident in this aspect.

- Previously, the "insert values" mode of record managers
  wasn't covered by the record manager tests.
- Django and Popo record managers didn't previously support
  "insert values" mode, which allows for notification IDs to
  be set in the application, and "non-notifiable" domain
  events (where the domain events aren't present in the
  notification log).
- Django, Popo, and SQLAlchemy record managers didn't
  previously reject non-integer values for notification IDs
  (which can cause problems).
- SQLAlchemy record manager wasn't using compiled insert
  statements where it could (ie when there are no ORM objects
  to insert). Still might be possible to use them with ORM
  objects, but it seems to need the connection rather than
  transaction and ORM objects seem to need the transaction
  rather than connection interface?
- Previously, test cases were using methods on subclasses
  of record manager but the factory method for the record
  manager was type-hinted with the superclass, so couldn't
  navigate to the method-under-test.
- Previously, the tracking record aspect of record managers
  wasn't being tested in the record manager test cases.

5762 of 6143 relevant lines covered (93.8%)

2.81 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2884.1 (CASSANDRA_HOSTS=127.0.0.1 MYSQL_USER=travis MYSQL_PASSWORD= POSTGRES_USER=postgres POSTGRES_PASSWORD=) 0
93.68
 Travis Job 2884.1
2 2884.2 (CASSANDRA_HOSTS=127.0.0.1 MYSQL_USER=travis MYSQL_PASSWORD= POSTGRES_USER=postgres POSTGRES_PASSWORD=) 0
93.73
 Travis Job 2884.2
3 2884.3 (CASSANDRA_HOSTS=127.0.0.1 MYSQL_USER=travis MYSQL_PASSWORD= POSTGRES_USER=postgres POSTGRES_PASSWORD=) 0
93.79
 Travis Job 2884.3
Source Files on build 2884