5238
0%

Ran 09 Jun 2015 05:14PM UTC

Jobs 10

Files 330

Run time 33min

Badge

Embed ▾

pending completion

Build # 5238

Build Type

push

travis-ci

Committed by

fkorotkov

Commit Message

Added a hash to a jar name for a bootstrapped jvm tool

Before fingerprints for scala and zinc for java tools were the same but the actual paths of shaded jars in artifacts were different. Removed scope and key from the jar_path and added a hash.

Example:

We compile a java target with Zinc and it will shade zinc and store it to an artifact. The artifact will contain only one jar file `bootstrap/bootstrap-jvm-tools/tool_cache/shaded_jars/compile.zinc-java/zinc/org.pantsbuild.zinc.Main.jar`.

Then we'll try to compile a Scala target and because the fingerprint is the same as for zinc-java it will use an artifact from zinc-java. But it will fail to locate a shaded jar at `bootstrap-jvm-tools/tool_cache/shaded_jars/compile.zinc/zinc/org.pantsbuild.zinc.Main.jar` and will shade it again.

Testing Done:
https://travis-ci.org/fkorotkov/pants/builds/65968176

Bugs closed: 1652

Reviewed at https://rbcommons.com/s/twitter/r/2334/

Run Details

13930 of 19850 relevant lines covered (70.18%)

1.32 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5238.1 (CI_FLAGS="-cjlpn 'Various pants self checks'")	09 Jun 2015 05:15PM UTC	0		Travis Job 5238.1
2	5238.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")	09 Jun 2015 05:14PM UTC	330	65.53	Travis Job 5238.2
3	5238.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")	09 Jun 2015 05:20PM UTC	330	66.38	Travis Job 5238.3
4	5238.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'")	09 Jun 2015 05:19PM UTC	0		Travis Job 5238.4
5	5238.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'")	09 Jun 2015 05:28PM UTC	0		Travis Job 5238.5
6	5238.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'")	09 Jun 2015 05:30PM UTC	0		Travis Job 5238.6
7	5238.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'")	09 Jun 2015 05:31PM UTC	0		Travis Job 5238.7
8	5238.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'")	09 Jun 2015 05:33PM UTC	0		Travis Job 5238.8
9	5238.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'")	09 Jun 2015 05:31PM UTC	0		Travis Job 5238.9
10	5238.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'")	09 Jun 2015 05:47PM UTC	0		Travis Job 5238.10

Source Files on build 5238

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

pantsbuild / pants / 5238
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5238

pantsbuild / pants / 5238 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5238

pantsbuild / pants / 5238
0%

README BADGES
x