pantsbuild / pants / 5237
0%
main: 93%

LAST BUILD BRANCH: fix-changed-since-whitespace-23307
DEFAULT BRANCH: main
Ran
Jobs 10
Files 330
Run time 15min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5237

push

travis-ci

jsirois 
Add support for ServiceLoader service providers.

Since ServiceLoader service providers are part of the jvm apis and we
support them already in the jar tool (concatenating service provider
configuration files by default when creating binaries), add support for
generating the service provider configuration files directly.

This change also refactors the existing `PrepareResources` class, moving
it from the core backend to jvm since it operated on jvm assumptions and
lifting its core machinery to a `ResourcesTask` base class.

Testing Done:
New test coverage:
```console
$ pants.dev test.pytest \
  --coverage=modules:pants.backend.jvm.tasks.resources_task,pants.backend.jvm.tasks.prepare_resources,pants.backend.jvm.tasks.prepare_services \
  tests/python/pants_test/backend/jvm/tasks/:{resources_task,prepare_{resources,services}}
...
13:28:02 00:01         [chroot]============== test session starts ===============
                     platform linux2 -- Python 2.7.8 -- py-1.4.28 -- pytest-2.6.4
                     plugins: timeout
                     collected 17 items

                     tests/python/pants_test/backend/jvm/tasks/test_resources_task.py ......
                     tests/python/pants_test/backend/jvm/tasks/test_prepare_resources.py .....
                     tests/python/pants_test/backend/jvm/tasks/test_prepare_services.py ......

                     =========== 17 passed in 0.69 seconds ============
                     Name                                                   Stmts   Miss Branch BrMiss  Cover
                     ----------------------------------------------------------------------------------------
                     src/python/pants/backend/jvm/tasks/prepare_resources      32      2      6      0    95%
                     src/python/pants/backend/jvm/tasks/prepare_services       31      0      6      0   100%
                     src/python/pants/backend/jvm/tasks/resources_task         54      2     24      2    95%
                     ----------------------------------------------------------------------------------------
                     TOTAL                                                    117      4     36      2    96%
...
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/66066808

Bugs closed: 1634, 1647

Reviewed at https://rbcommons.com/s/twitter/r/2331/

13878 of 19848 relevant lines covered (69.92%)

1.31 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5237.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 0
Travis Job 5237.1
2 5237.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 0
65.28
 Travis Job 5237.2
3 5237.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 0
66.08
 Travis Job 5237.3
4 5237.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 0
Travis Job 5237.4
5 5237.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 0
Travis Job 5237.5
6 5237.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 0
Travis Job 5237.6
7 5237.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 0
Travis Job 5237.7
8 5237.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 0
Travis Job 5237.8
9 5237.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 0
Travis Job 5237.9
10 5237.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 0
Travis Job 5237.10
Source Files on build 5237
Detailed source file information is not available for this build.