13530
100%

Ran 30 Apr 2015 08:17PM UTC

Jobs 1

Files 2171

Run time 95min

Badge

Embed ▾

pending completion

Build # 13530

Build Type

Pull #7474

travis-ci

Committed by

weierophinney

Commit Message

[#7445/#7448] Repair BC break

This patch clarifies the interaction of the various flags when
validating an input. In it, I added test cases for the various
behaviors

- `required === true` + `allow_empty === true` + `continue_if_empty === false` -> validators are NOT run
- `required === true` + `allow_empty === true` + `continue_if_empty === true` -> validators are run
- `required === false` + `allow_empty === true` + `continue_if_empty === false` -> validators are NOT run
- `required === false` + `allow_empty === true` + `continue_if_empty === true` -> validators are run
- `required === false` + `allow_empty === false` + `continue_if_empty === false` -> validators are NOT run
- `required === false` + `allow_empty === false` + `continue_if_empty === true` -> validators are run

Changes were applied to `setRequired()`, which now no longer toggles
`allow_empty`, and the logic in `Input::isValid()` and
`FileInput::isValid()` was updated to match the above.

Two tests were removed as they were testing false assumptions:

- `BaseInputFilterTest::testValidationMarksInputInvalidWhenNotRequiredAndAllowEmptyFlagIsFalse`
- `FactoryTest::testFactoryWillCreateInputWithSuggestedRequiredFlagAndImpliesAllowEmptyFlag`

Pull Request Pull Request #7474: Implement expected Input::isValid workflow

Run Details

63898 of 78677 relevant lines covered (81.22%)

37.68 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	91.67	0.0%	library/Zend/Db/Sql/Select.php
1	87.88	0.0%	library/Zend/View/Helper/Escaper/AbstractHelper.php
1	49.22	0.0%	library/Zend/Session/Storage/AbstractSessionArrayStorage.php
1	91.89	0.0%	library/Zend/Session/AbstractContainer.php
1	100.0	0.0%	library/Zend/Filter/FilterPluginManager.php
2	97.3	0.2%	library/Zend/InputFilter/FileInput.php
2	83.33	0.0%	library/Zend/Db/Adapter/Driver/Pdo/Result.php
3	94.9	0.22%	library/Zend/InputFilter/Input.php
4	91.92	0.0%	library/Zend/View/Model/ViewModel.php
5	94.81	0.0%	library/Zend/Db/Sql/Insert.php
6	85.71	0.0%	library/Zend/Filter/Word/AbstractSeparator.php
7	91.3	0.0%	library/Zend/Db/Sql/Expression.php

Jobs

ID	Job ID	Ran	Files	Coverage
4	13530.4	30 Apr 2015 08:15PM UTC	2171	81.22	Travis Job 13530.4

Source Files on build 13530

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

zendframework / zf2 / 13530
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 13530

zendframework / zf2 / 13530 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 13530

zendframework / zf2 / 13530
100%

README BADGES
x