13530

pending completion

Build # 13530

Build Type

Pull #7474

travis-ci

Committed by

weierophinney

Commit Message

[#7445/#7448] Repair BC break

This patch clarifies the interaction of the various flags when
validating an input. In it, I added test cases for the various
behaviors

- `required === true` + `allow_empty === true` + `continue_if_empty === false` -> validators are NOT run
- `required === true` + `allow_empty === true` + `continue_if_empty === true` -> validators are run
- `required === false` + `allow_empty === true` + `continue_if_empty === false` -> validators are NOT run
- `required === false` + `allow_empty === true` + `continue_if_empty === true` -> validators are run
- `required === false` + `allow_empty === false` + `continue_if_empty === false` -> validators are NOT run
- `required === false` + `allow_empty === false` + `continue_if_empty === true` -> validators are run

Changes were applied to `setRequired()`, which now no longer toggles
`allow_empty`, and the logic in `Input::isValid()` and
`FileInput::isValid()` was updated to match the above.

Two tests were removed as they were testing false assumptions:

- `BaseInputFilterTest::testValidationMarksInputInvalidWhenNotRequiredAndAllowEmptyFlagIsFalse`
- `FactoryTest::testFactoryWillCreateInputWithSuggestedRequiredFlagAndImpliesAllowEmptyFlag`

Pull Request Pull Request #7474: Implement expected Input::isValid workflow

Run Details

63898 of 78677 relevant lines covered (81.22%)

37.68 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

49.22

/library/Zend/Session/Storage/AbstractSessionArrayStorage.php

Build SHA Not Found

The commit SHA "25ffe830e7331f8d529361ed2c238665dfcae9a8" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

zendframework / zf2 / 13530

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous