4
100%
master: 100%

Ran 30 Apr 2015 08:17PM UTC

Files 2171

Run time 95min

Badge

Embed ▾

Committed 30 Apr 2015 07:51PM UTC coverage: 81.216% (+0.003%) from 81.213%

Job # 13530.4

Build Type

Pull #7474

travis-ci

Committed by

weierophinney

Commit Message

[#7445/#7448] Repair BC break

This patch clarifies the interaction of the various flags when
validating an input. In it, I added test cases for the various
behaviors

- `required === true` + `allow_empty === true` + `continue_if_empty === false` -> validators are NOT run
- `required === true` + `allow_empty === true` + `continue_if_empty === true` -> validators are run
- `required === false` + `allow_empty === true` + `continue_if_empty === false` -> validators are NOT run
- `required === false` + `allow_empty === true` + `continue_if_empty === true` -> validators are run
- `required === false` + `allow_empty === false` + `continue_if_empty === false` -> validators are NOT run
- `required === false` + `allow_empty === false` + `continue_if_empty === true` -> validators are run

Changes were applied to `setRequired()`, which now no longer toggles
`allow_empty`, and the logic in `Input::isValid()` and
`FileInput::isValid()` was updated to match the above.

Two tests were removed as they were testing false assumptions:

- `BaseInputFilterTest::testValidationMarksInputInvalidWhenNotRequiredAndAllowEmptyFlagIsFalse`
- `FactoryTest::testFactoryWillCreateInputWithSuggestedRequiredFlagAndImpliesAllowEmptyFlag`

Pull Request Pull Request #7474: Implement expected Input::isValid workflow

Run Details

63898 of 78677 relevant lines covered (81.22%)

37.68 hits per line

zendframework / zf2 / 13530 / 4
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13530.4

zendframework / zf2 / 13530 / 4 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13530.4

zendframework / zf2 / 13530 / 4
100%
master: 100%

README BADGES
x