pantsbuild / pants / 4625
0%
main: 93%

LAST BUILD BRANCH: use_pants_lock_in_uv
DEFAULT BRANCH: main
Ran
Jobs 10
Files 324
Run time 10min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
4625

push

travis-ci

stuhood 
Only add resources to the relevant target

PrepareResources was adding a toposorted list of entries to the classpath for ALL targets, rather than the specific resource target that should have been receiving them.

Perhaps because:
1. the toposort implementation preserves the order of the inputs in cases where they don't have dependencies
2. goal `run.jvm` requires a single target, which would mean that the context would already be ordered for that target
3. goal `test.junit` is currently mostly-insane in terms of resources (all of everything on the classpath: definite TODO)
...this was resulting in a somewhat-correct (?) ordering of resources at execution time, at least for targets that cared. But if you requested the resources for a particular target using `compile_classpath.get_for_target(t)`, you would get things that you did not depend on.

Fixing that problem exposed the fact that depth-first search (DFS) is not the right way to sort dependencies for the JVM. The JVM needs the highest priority items first on the classpath, and in the case of a depgraph, this means that the nearest items (ie: self, then direct deps, and then their deps, etc) need to be listed first. This calls for breadth-first search (BFS.)

- Add implementation of bfs for dependency graph traversals and use it UnionProducts
- Only add resources to the relevant target
- Move build_graph tests to the appropriate package

Testing Done:
https://github.com/pantsbuild/pants/pull/1438

Reviewed at https://rbcommons.com/s/twitter/r/2103/

13330 of 19100 relevant lines covered (69.79%)

0.7 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4625.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'") 0
Travis Job 4625.1
2 4625.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'") 0
Travis Job 4625.2
3 4625.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'") 0
69.79
 Travis Job 4625.3
4 4625.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'") 0
Travis Job 4625.4
5 4625.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'") 0
Travis Job 4625.5
6 4625.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'") 0
Travis Job 4625.6
7 4625.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'") 0
Travis Job 4625.7
8 4625.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'") 0
Travis Job 4625.8
9 4625.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'") 0
Travis Job 4625.9
10 4625.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'") 0
Travis Job 4625.10
Source Files on build 4625
Detailed source file information is not available for this build.