4618
0%
main: 93%

Ran 25 Apr 2015 10:56PM UTC

Jobs 10

Files 324

Run time 12min

Badge

Embed ▾

pending completion

Build # 4618

Build Type

push

travis-ci

Committed by

ericzundel

Commit Message

Address Stu's comment from https://rbcommons.com/s/twitter/r/2084

There was an unintentional indent when adding new context manager for self.create_jar_builder()

Testing Done:
```
git diff HEAD~20 src/python/pants/backend/jvm/tasks/jvm_binary_task.py
diff --git a/src/python/pants/backend/jvm/tasks/jvm_binary_task.py b/src/python/pants/backend/jvm/tasks/jvm_binary_task.py
index 50787d0..518507a 100644
--- a/src/python/pants/backend/jvm/tasks/jvm_binary_task.py
+++ b/src/python/pants/backend/jvm/tasks/jvm_binary_task.py
@@ -69,7 +69,8 @@ class JvmBinaryTask(JarTask):
                          compressed=True) as jar:

         with self.context.new_workunit(name='add-internal-classes'):
-          self.create_jar_builder(jar).add_target(binary, recursive=True)
+          with self.create_jar_builder(jar) as jar_builder:
+            jar_builder.add_target(binary, recursive=True)

         if with_external_deps:
           with self.context.new_workunit(name='add-dependency-jars'):
```

Bugs closed: 1452

Reviewed at https://rbcommons.com/s/twitter/r/2119/

Coverage Stats

13323 of 19087 relevant lines covered (69.8%)

0.7 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4618.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'")	25 Apr 2015 10:58PM UTC		Travis Job 4618.1
2	4618.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'")	25 Apr 2015 10:56PM UTC		Travis Job 4618.2
3	4618.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")	25 Apr 2015 10:59PM UTC	69.8	Travis Job 4618.3
4	4618.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'")	25 Apr 2015 10:56PM UTC		Travis Job 4618.4
5	4618.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'")	25 Apr 2015 10:57PM UTC		Travis Job 4618.5
6	4618.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'")	25 Apr 2015 11:09PM UTC		Travis Job 4618.6
7	4618.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'")	25 Apr 2015 11:05PM UTC		Travis Job 4618.7
8	4618.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'")	25 Apr 2015 11:04PM UTC		Travis Job 4618.8
9	4618.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'")	25 Apr 2015 11:05PM UTC		Travis Job 4618.9
10	4618.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'")	25 Apr 2015 11:05PM UTC		Travis Job 4618.10

Source Files on build 4618

Detailed source file information is not available for this build.

pantsbuild / pants / 4618
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4618

pantsbuild / pants / 4618 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4618

pantsbuild / pants / 4618
0%
main: 93%

README BADGES
x