pantsbuild / pants / 4156

0%

main: 93%

push

travis-ci

Get rid of almost all direct config access in python-building code.

- Instead, relies more heavily on the existing PythonSetup class,
  and a new sibling called PythonRepos.
- These are basically proto-subsystems, and we'll retrofit them
  to be part of the subsystem mechanism once we invent that.
- Removes some unnecessary degrees of freedom in config.
   For example, there's no reason to allow names of working and scratch dirs
   to be configurable.
- Cleans up and streamlines the code.
- Moves some standalone functions into classes, for a more natural design.
- Refactors a test for better code reuse.

Testing Done:
CI passes: https://travis-ci.org/pantsbuild/pants/builds/55115225

Tried various manual python builds.

Reviewed at https://rbcommons.com/s/twitter/r/1954/

105 of 105 new or added lines in 5 files covered. (100.0%)

12734 of 18378 relevant lines covered (69.29%)

0.69 hits per line