graphql / graphql-js / 2728

99%

master: 98%

push

travis-ci

Test: Missing subscription field should not be an "internal error"

A remaining issue with subscriptions is attempting to subscribe to a missing field. The existing implementation creates an internal error which is an improper blame since there is no possibility to fix it internally - it is an issue with the query.

For consistency with the same scenario for query/mutation operations, this simply returns nothing. I interpret the equivalent of "undefined" for a subscribe operation as an empty iteration.

Note: this will require spec changes, however spec changes are necessary either way to resolve the ambiguity of this exact scenario.

3897 of 4391 branches covered (88.75%)

14 of 14 new or added lines in 3 files covered. (100.0%)

9431 of 9543 relevant lines covered (98.83%)

1295.76 hits per line