• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

graphql / graphql-js / 2757
99%
master: 98%

Build:
Build:
LAST BUILD BRANCH: directives
DEFAULT BRANCH: master
Ran 06 Dec 2017 07:17PM UTC
Jobs 1
Files 172
Run time 10min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2757

push

travis-ci

leebyron
Test: Missing subscription field should not be an "internal error"

A remaining issue with subscriptions is attempting to subscribe to a missing field. The existing implementation creates an internal error which is an improper blame since there is no possibility to fix it internally - it is an issue with the query.

Since there is no clear consistent behavior relative to query/mutation operations (which simply skip over unknown fields), and the corner-case where this occurs should deal with the error - this changes the internal error to an external yielded GraphQL error.

Note: we still require a spec change since there is an ambiguity of this exact scenario.

3875 of 4360 branches covered (88.88%)

7 of 7 new or added lines in 2 files covered. (100.0%)

9442 of 9552 relevant lines covered (98.85%)

1304.93 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
src/error/GraphQLError.js
3
100.0
src/execution/execute.js
3
100.0
src/subscription/__tests__/subscribe-test.js
Jobs
ID Job ID Ran Files Coverage
1 2757.1 06 Dec 2017 07:17PM UTC 0
98.85
Travis Job 2757.1
Source Files on build 2757
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2757
  • aac2a5ef on github
  • Prev Build on missing-subscription-field (#2728)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc