• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

graphql / graphql-js / 2676
99%
master: 98%

Build:
Build:
LAST BUILD BRANCH: directives
DEFAULT BRANCH: master
Ran 02 Dec 2017 02:29AM UTC
Jobs 1
Files 169
Run time 16s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2676

push

travis-ci

leebyron
Test: Missing subscription field should not be an "internal error"

A remaining issue with subscriptions is attempting to subscribe to a missing field. The existing implementation creates an internal error which is an improper blame since there is no possibility to fix it internally - it is an issue with the query.

For consistency with the same scenario for query/mutation operations, this simply returns nothing. I interpret the equivalent of "undefined" for a subscribe operation as an empty iteration.

Note: this will require spec changes, however spec changes are necessary either way to resolve the ambiguity of this exact scenario.

3859 of 4347 branches covered (88.77%)

14 of 14 new or added lines in 3 files covered. (100.0%)

9376 of 9488 relevant lines covered (98.82%)

1290.38 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
100.0
src/subscription/emptyAsyncIterator.js
Jobs
ID Job ID Ran Files Coverage
1 2676.1 02 Dec 2017 02:29AM UTC 0
98.82
Travis Job 2676.1
Source Files on build 2676
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2676
  • c78e33ff on github
  • Next Build on missing-subscription-field (#2728)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc