3063
98%

Ran 06 Oct 2017 03:53PM UTC

Jobs 2

Files 2

Run time 20s

Badge

Embed ▾

pending completion

Build # 3063

Build Type

Pull #1691

travis-ci

Committed by

web-flow

Commit Message

Fix validations nested under a `given`

Multi-param and default validators, all of which implemented their
own `validate!` method, were not respecting the `given` dependency
as expected. This change copies the check into all those validators.

The bug was likely introduced by #1625, which required that the
dependency check be moved out of the scope itself and into the
validators. Rolling back that change would require fundamentally
re-architecting how array parameters are validated (possibly with
a new kind of scope).

Pull Request Pull Request #1691: [Bug] Fix validations nested under a `given`

Run Details

6 of 10 relevant lines covered (60.0%)

0.6 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	60.0	-40.0%	lib/grape/util/xml.rb

Jobs

ID	Job ID	Ran	Files	Coverage
7	3063.7 (2.4.1, gemfiles/multi_json.gemfile)	06 Oct 2017 03:53PM UTC	1	60.0	Travis Job 3063.7
8	3063.8 (2.4.1, gemfiles/multi_xml.gemfile)	06 Oct 2017 03:53PM UTC	1	60.0	Travis Job 3063.8

Source Files on build 3063

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

ruby-grape / grape / 3063
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3063

ruby-grape / grape / 3063 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3063

ruby-grape / grape / 3063
98%

README BADGES
x