3063

pending completion

Build # 3063

Build Type

Pull #1691

travis-ci

Committed by

web-flow

Commit Message

Fix validations nested under a `given`

Multi-param and default validators, all of which implemented their
own `validate!` method, were not respecting the `given` dependency
as expected. This change copies the check into all those validators.

The bug was likely introduced by #1625, which required that the
dependency check be moved out of the scope itself and into the
validators. Rolling back that change would require fundamentally
re-architecting how array parameters are validated (possibly with
a new kind of scope).

Pull Request Pull Request #1691: [Bug] Fix validations nested under a `given`

Run Details

6 of 10 relevant lines covered (60.0%)

0.6 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.0

/lib/grape/util/xml.rb

Build SHA Not Found

The commit SHA "f4490108d159fec220112c0e7b974099b89d6c57" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

ruby-grape / grape / 3063

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous