• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

helpscout / blue / 62
100%

Build:
DEFAULT BRANCH: master
Ran 05 Sep 2017 05:52PM CUT
Jobs 1
Files 56
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
62

Pull #20

travis-ci

web-flow
Choice: Fix ID generation

This update fixes the `uniqueID()` generation for the `Choice` component, which indirectly fixes it for `Checkbox` and `Radio`. The same fix was also applied to `Input` and `PortalWrapper`.

This issue was the element's ID was being regenerated everytime there was a prop change, which is incorrect. It should only be generated once. The solution was to generate and store the uniqueID in the component state, instead of creating it in the render hook.

The uniqueID creation factory function has also been enhanced to accept a prefix override namespace.
Pull Request #20: Choice: Fix ID generation

345 of 345 branches covered (100.0%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 5 files covered. (100.0%)

564 of 564 relevant lines covered (100.0%)

35.62 hits per line

Jobs
ID Job ID Ran Files Coverage
1 62.1 05 Sep 2017 05:52PM CUT 0
100.0
Travis Job 62.1
Source Files on build 62
  • List 0
  • Changed 13
  • Source Changed 8
  • Coverage Changed 12
Loading...
Coverage∆FileLinesRelevantCoveredMissedHits/LineBranch HitsBranch Misses
No data available in table
Showing 0 to 0 of 0 entries
  • Previous
  • Next
  • Back to Repo
  • Travis Build #62
  • Pull Request #20
  • PR Base - master (#60)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc