Instagram / IGListKit / 1472
100%

DEFAULT BRANCH: master
Ran
Jobs 4
Files 87
Run time 524min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1472

push

travis-ci

Facebook Github Bot 
<a href="https://github.com/Instagram/IGListKit/commit/40625f8ff">Swift name annotations

Summary:
This adds `NS_SWIFT_NAME` annotations to all public API&#39;s to provide cleaner integration into Swift:

- Removes the need to prefix classes in Swift code, instead rely on Swift module name spacing
- Adds more argument labels to C function API&#39;s like `IGListDiff([], [], .equality)` =&gt; `ListDiff(oldArray: [], newArray: [], option: .equality)`

While this is a large API change it should be as easy as:

- Find and replace `(IGList)([^K])` to `List$2` in Xcode with a scope set to Swift
- Build and follow compiler&#39;s auto fix corrections for C API&#39;s or any missed renames

I have not updated the documentation to reflect this yet, I am totally willing to do so but before I sink that amount of time into it I wanted to see if the Instagram team is even open to this change!

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn&#39;t tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
- [ ] I have updated the documentation
Closes https://github.com/Instagram/IGListKit/pull/593

Reviewed By: jessesquires

Differential Revision: D5028039

Pulled By: rnystrom

fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/b473d874a">b473d874a</a>

10074 of 10320 relevant lines covered (97.62%)

488.5 hits per line

Jobs
ID Job ID Ran Files Coverage
9 1472.9 (DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.62
 Travis Job 1472.9
10 1472.10 (DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.62
 Travis Job 1472.10
11 1472.11 (DESTINATION="OS=10.2,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.62
 Travis Job 1472.11
12 1472.12 (DESTINATION="OS=10.3,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO") 0
97.62
 Travis Job 1472.12
Source Files on build 1472
Detailed source file information is not available for this build.