1461
100%

Ran 09 May 2017 03:26PM UTC

Jobs 4

Files 87

Run time 928min

Badge

Embed ▾

pending completion

Build # 1461

Build Type

push

travis-ci

Committed by

facebook-github-bot

Commit Message

<a href="https://github.com/Instagram/IGListKit/commit/a4dfe9676">Fix reusing collection views among multiple adapters

Summary:
When multiple `UICollectionView`s are reused among multiple `IGListAdapter`s (horizontal lists embedded in a bigger, vertical list), the mapping between the old view and adapter is not broken. When a new collection view is attached to the old adapter, an unrelated adapter-&gt;collection view reference will be erroneously broken.

The unit test in this diff fails on the second `XCTAssertEqual(adapter2.collectionView, collectionView1);` without this patch.

Issue fixed: #699

t15661237 internally

cc amonshiz since we were talking about this

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn&#39;t tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
Closes https://github.com/Instagram/IGListKit/pull/721

Reviewed By: amonshiz

Differential Revision: D5026330

Pulled By: rnystrom

fbshipit-source-id: </a><a class="double-link" href="https://github.com/Instagram/IGListKit/commit/b2164a4ab">b2164a4ab</a>

Run Details

10074 of 10320 relevant lines covered (97.62%)

488.51 hits per line

Jobs

ID	Job ID	Ran	Coverage
9	1461.9 (DESTINATION="OS=10.0,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="YES" RUN_UI_TESTS="NO" POD_LINT="NO")	09 May 2017 03:29PM UTC	97.62	Travis Job 1461.9
10	1461.10 (DESTINATION="OS=10.1,name=iPhone 6s" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO")	09 May 2017 03:27PM UTC	97.62	Travis Job 1461.10
11	1461.11 (DESTINATION="OS=10.2,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO")	09 May 2017 03:26PM UTC	97.62	Travis Job 1461.11
12	1461.12 (DESTINATION="OS=10.3,name=iPad Air 2" SDK="$IOS_SDK" SCHEME="$IOS_SCHEME" RUN_TESTS="YES" BUILD_EXAMPLE="NO" RUN_UI_TESTS="NO" POD_LINT="NO")	09 May 2017 03:26PM UTC	97.62	Travis Job 1461.12

Source Files on build 1461

Detailed source file information is not available for this build.

Instagram / IGListKit / 1461
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1461

Instagram / IGListKit / 1461 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1461

Instagram / IGListKit / 1461
100%

README BADGES
x