You are now the owner of this repo.

hyperledger-labs / fabric-smart-client
71%

DEFAULT BRANCH: main
Repo Added
Token 2ZD9nBTBJg6N8NJjhbgg4nAhR8SewdDLj regen
Build 985 Last
Files 539
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 71.233% (+0.04%) from 71.197%
26634201560

push

github

web-flow 
perf(bft): per-orderer channel-slot pool to fix semaphore mutex starvation (#1490)

BFTBroadcaster.getConnection serialized every caller through the single
sync.Mutex inside a shared golang.org/x/sync/semaphore.Weighted, and spun
on a 1s-timeout Acquire retry loop when the pool was empty. Under high
broadcast concurrency this collapses into mutex starvation: every
broadcaster contends on the one semaphore regardless of which orderer it
dials, and a caller whose context is cancelled mid-acquire busy-spins
because the loop has no ctx.Done() exit.

Replace the global semaphore with per-orderer state:
  - a fixed-capacity channel of slot tokens that bounds connections per
    orderer without a mutex shared across orderers, and
  - a buffered pool of idle *Connection for reuse.

getConnection becomes a three-stage, non-spinning acquire (try pool, try
slot, then block on a select over pool / slot / ctx.Done()). SendAndRecv
wraps the send+recv round-trip in a derived context so a hung Recv is
cancelled and torn down instead of leaking.

Tests: adapt the partial-failure discard test to the per-orderer slot
accounting, and add a regression test that getConnection returns promptly
on a cancelled context.

Observed in our deployment (c=1000 stress): submit p99 6.18s -> 1.59s,
678 TPS sustained.

Signed-off-by: Evan <evanyan@sign.global>

84 of 118 new or added lines in 2 files covered. (71.19%)

11 existing lines in 4 files now uncovered.

28425 of 39904 relevant lines covered (71.23%)

2515.62 hits per line

Relevant lines Covered
39904 RELEVANT LINES 28425 COVERED LINES
2515.62 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26634201560 main perf(bft): per-orderer channel-slot pool to fix semaphore mutex starvation (#1490) BFTBroadcaster.getConnection serialized every caller through the single sync.Mutex inside a shared golang.org/x/sync/semaphore.Weighted, and spun on a 1s-timeout A... push web-flow github
71.23
26617926180 upstream-pr/bft-channel-slot Merge cf57d7ae5 into 4544a0cd0 Pull #1490 web-flow github
71.24
26617101801 upstream-pr/bft-channel-slot Merge 71255f8da into 4544a0cd0 Pull #1490 web-flow github
71.22
26596973206 feat/copy-query-builder-to-fabric-vault Merge f4bb0ebe7 into 4544a0cd0 Pull #1478 web-flow github
70.9
26580051470 go-kit Merge 4d930cc45 into 4544a0cd0 Pull #1488 web-flow github
71.22
26579103782 main fix(fabric/ordering): always discard failed connections in BFT broadcast (#1485) * fix(fabric/ordering): always discard failed connections in BFT broadcast Broadcast() only ran its usedConnections cleanup on the overall-failure path. When a broa... push web-flow github
71.2
26577972700 fix/bft-broadcast-discard-on-success Merge 07ef4feda into 328bc541b Pull #1485 web-flow github
71.21
26577080922 go.yaml Merge 21cc3e503 into 328bc541b Pull #1486 web-flow github
70.93
26576347505 go.yaml Merge cdfcbb401 into 328bc541b Pull #1486 web-flow github
70.97
26570305140 main Enable TLS for Fabric-X Committer Container (#1298) * refactor(fabricx)!: Enable TLS for committer all-in-one container in fabric-x integration tests Signed-off-by: Shashank <yshashank959@gmail.com> Signed-off-by: Marcus Brandenburger <bur@zuri... push web-flow github
70.95
See All Builds (713)

Badge your Repo: fabric-smart-client

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh