hyperledger-labs / fabric-smart-client
81%

DEFAULT BRANCH: main
Repo Added
Token 2ZD9nBTBJg6N8NJjhbgg4nAhR8SewdDLj regen
Build 1336 Last
Files 532
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x
Sync Branches

coverage: 81.234% (+0.02%) from 81.215%
29900688672

push

github

web-flow 
revert(security): stop redacting responder-view errors sent to remote callers (#1600)

* revert(security): stop redacting responder-view errors sent to remote callers

13c5d99b (#1594) changed Service.respond to send back a generic
"responder failed" string instead of the responder view's actual error,
to avoid leaking internal error/panic detail to a remote peer.

In practice this also erases legitimate business-logic error detail that
callers rely on: a responder view (e.g. an auditor rejecting a transfer
for exceeding a payment limit) returns a business error, not a leak, and
callers across the wire need that text to make decisions and to assert
on it in tests. Downstream, this broke Fabric Token SDK / Panurus
integration tests that check for the specific rejection reason returned
by a remote auditor (payment/holding limit messages, "is not valid",
etc.) - see LFDT-Panurus/panurus#1969.

Revert to sending back the responder's actual err.Error(), matching
respond()'s pre-#1594 behavior in this regard. The rest of #1594
(wire-deserialization validation, endorsement verification hardening)
is unaffected and stays in place.

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* docs: clarify that responder-error content is the application's call

Documents the design principle behind the revert in 12ab47c2: the P2P
runner decides that an error is returned to the remote caller, not what
it contains. SendError forwards err.Error() verbatim, and filtering or
redacting sensitive detail is the responder view's responsibility.

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

5 existing lines in 2 files now uncovered.

32103 of 39519 relevant lines covered (81.23%)

3092.91 hits per line

Relevant lines Covered
39519 RELEVANT LINES 32103 COVERED LINES
3092.91 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
29900688672 main revert(security): stop redacting responder-view errors sent to remote callers (#1600) * revert(security): stop redacting responder-view errors sent to remote callers 13c5d99b (#1594) changed Service.respond to send back a generic "responder fail... push web-flow github
81.23
29835686127 main ci(coverage): honour caller -coverpkg from GOFLAGS in integration builds (#1596) Signed-off-by: AkramBitar <akram@il.ibm.com> push web-flow github
81.21
29824794131 main chore(deps): bump pillow in /integration/benchmark/plots (#1597) Bumps [pillow](https://github.com/python-pillow/Pillow) from 12.2.0 to 12.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/p... push web-flow github
81.22
29744281276 main fix(security): harden responder-view input validation and endorsement checks (#1594) * fix(security): harden responder-view input validation and endorsement checks Malformed or adversarial input from a remote peer over a P2P session could panic ... push web-flow github
81.22
29511349006 main ci(coverage): integration tests now really contribute to the coverage report (#1591) * ci(coverage): drop Coveralls carryforward that masked missing itest jobs Signed-off-by: Said Altury <Said.Altury@ibm.com> * integration/integration.go (-cove... push web-flow github
81.19
29499190625 main refactor(metrics): drop version gauge caching workaround (#1587) The prometheus provider now caches collectors (#1582), so the package-level singleton guarding fsc_version registration is redundant. Signed-off-by: Evan <evanyan@sign.global> push web-flow github
74.14
29498328195 main fix(fabricx): deterministic vault Marshaller.Marshal (#1590) Signed-off-by: Angelo De Caro <adc@zurich.ibm.com> push web-flow github
74.14
29493265520 main feature(fabric-x): add GetNamespacePolicies to query service (#1584) Signed-off-by: Said Altury <Said.Altury@ibm.com> push web-flow github
74.05
29487017076 main Add configurable size limit for outgoing P2P messages (#1580) * Add configurable size limit for outgoing P2P messages Signed-off-by: Shashank <yshashank959@gmail.com> push web-flow github
74.05
29484837588 main fix(metrics): cache collectors in the prometheus provider (#1582) * fix(metrics): cache collectors in the prometheus provider Repeated requests for the same metric built a fresh collector whose registration failed; with SkipRegisterErr set the e... push web-flow github
74.04
See All Builds (1006)

Badge your Repo: fabric-smart-client

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh