liran-funaro / fabric-x-committer

91%

main: 92%

LAST BUILD ON BRANCH loadgen-config-cleanup

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• apt-ci-fix
• auto-merge-fix
• backoff-v5
• backoff-v5-orig
• bccsp-race
• bft-delivery
• bft-metrics
• bob-reduce-context
• bob-rules
• bob-skills
• buffer-race
• channel-race
• ci-gotestsum
• client-test-race
• coord-queue-deadlock
• coordinator-metadata-fix
• coordinator-test-no-db
• coveralls
• cryptogen-recreate-support
• deliver-check-block-order
• deliver-seek-tls-cert
• deliver-seek-tls-cert-fix
• deliverorderer-tests
• delivery-data-blocks
• dependencygraph-race
• doc-loadgen-artifacts
• doc-scale-notify
• docker-moby-update
• external-server-config
• fabric-lib-go-v1.1.3
• find-bad-imports
• fix-automatic-env
• flaky-coordinator-test-615
• grpc-logger-fix
• homegrown-validator
• http-endpoint
• ledger-service-wait-behaviour
• llm-adjust
• loadgen-config-cleanup
• loadgen-const-distribution-shorthand
• loadgen-index-addressable-keys
• loadgen-manual-msp
• loadgen-probability-validation
• loadgen-remove-ctx
• loadgen-remove-query
• main
• make-fixes
• makefile-lints
• makefile-test-flags
• metrics-bob-rules
• metrics-url-race
• mock-orderer-direct-config
• mock-orderer-features
• mock-orderer-stream-holder
• mock-verifier-race
• move-retry-package
• move-testcrypto-to-common
• notify-full-block
• notify-tx-metadata
• orderer-config-race
• rebase-helper
• refactor-test
• remove-file
• remove-ifrit-gomega
• remove-loadgen-distribution
• remove-non-maintained-pkg
• retry-infinite-max-elapsed-time
• service-manager
• sidecar-block-store-code-fix
• sidecar-diagram-mod
• sidecar-diagrm
• sidecar-race
• sidecar-recover-inline
• sidecar-remove-chan-id
• sidecar-unified
• skill-dev
• sustain-config
• template-tls-per-endpoint
• test-container-port-binding
• test-coverage-connection
• test-coverage-improve
• test-coverage-latency
• test-coverage-tests
• test-minor-fixes
• test-query-status
• test-tls-flatten
• testcrypto-race
• testcrypto-refactor
• tx-metadata
• unused-code
• update-dep-4
• update-depenencies-3
• vc-race
• vc-resource-leak
• verifier-test-remove-gomega
• verifier-timeout
• viper-default-annot

Build # 30002056381

Build Type

push

github

Committed by liran-funaro

Commit Message

[loadgen] Consolidate workload config into TransactionProfile

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

Consolidate the loadgen workload config ahead of the index-addressable workload change;
no behavior change:

- Fold `key.size` (`KeyProfile`) into `TransactionProfile.KeySize`; delete `KeyProfile`.
- Fold `invalid-signatures` and `dependencies` into `TransactionProfile`; delete
  `ConflictProfile`. `DependencyDescription` and the dependency-conflict machinery
  (`dependenciesModifier`) are unchanged — only their config home moves.
- Inline invalid-signature stamping into the generator and drop `signTxModifier`; the
  per-worker bernoulli decision and dummy endorsement are unchanged. The generic
  `Modifier` mechanism stays (still used by `dependenciesModifier`).
- Move `key-size`, `invalid-signatures`, and `dependencies` under `transaction` in the
  config sample and template.

#### Additional details (Optional)

The generation seed order is preserved (the inlined invalid-signature RNG consumes the
seed where `signTxModifier` did), so the generated workload is byte-identical to before.
The coordinator's BenchmarkDependencyGraph is unchanged except for the moved field
reference (`p.Conflicts.Dependencies` -> `p.Transaction.Dependencies`).

Verified: `go build ./...`, `go vet`, `make lint-go` (0 issues), and the affected unit
tests (`loadgen/workload` incl. the dependency/modifier/invalid-signature tests, and
`cmd/config` loadgen decode/validation/env-override).

#### Related issues

- resolves #698

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

10279 of 11259 relevant lines covered (91.3%)

34723.36 hits per line