liran-funaro / fabric-x-committer

92%

main: 92%

LAST BUILD ON BRANCH remove-loadgen-distribution

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• apt-ci-fix
• backoff-v5
• backoff-v5-orig
• bccsp-race
• bft-delivery
• bft-metrics
• bob-reduce-context
• bob-rules
• bob-skills
• buffer-race
• channel-race
• ci-gotestsum
• client-test-race
• coord-queue-deadlock
• coordinator-metadata-fix
• coordinator-test-no-db
• coveralls
• cryptogen-recreate-support
• deliver-check-block-order
• deliver-seek-tls-cert
• deliver-seek-tls-cert-fix
• deliverorderer-tests
• delivery-data-blocks
• dependencygraph-race
• doc-loadgen-artifacts
• doc-scale-notify
• docker-moby-update
• external-server-config
• fabric-lib-go-v1.1.3
• find-bad-imports
• fix-automatic-env
• flaky-coordinator-test-615
• grpc-logger-fix
• homegrown-validator
• http-endpoint
• ledger-service-wait-behaviour
• llm-adjust
• loadgen-const-distribution-shorthand
• loadgen-manual-msp
• loadgen-remove-ctx
• loadgen-remove-query
• main
• make-fixes
• makefile-lints
• makefile-test-flags
• metrics-bob-rules
• metrics-url-race
• mock-orderer-direct-config
• mock-orderer-features
• mock-orderer-stream-holder
• mock-verifier-race
• move-retry-package
• move-testcrypto-to-common
• notify-full-block
• notify-tx-metadata
• orderer-config-race
• rebase-helper
• refactor-test
• remove-file
• remove-ifrit-gomega
• remove-loadgen-distribution
• remove-non-maintained-pkg
• retry-infinite-max-elapsed-time
• service-manager
• sidecar-block-store-code-fix
• sidecar-diagram-mod
• sidecar-diagrm
• sidecar-race
• sidecar-recover-inline
• sidecar-remove-chan-id
• sidecar-unified
• sustain-config
• template-tls-per-endpoint
• test-container-port-binding
• test-coverage-connection
• test-coverage-improve
• test-coverage-latency
• test-coverage-tests
• test-minor-fixes
• test-query-status
• test-tls-flatten
• testcrypto-race
• testcrypto-refactor
• tx-metadata
• unused-code
• update-dep-4
• update-depenencies-3
• vc-race
• vc-resource-leak
• verifier-test-remove-gomega
• verifier-timeout
• viper-default-annot

Build # 29749685031

Build Type

push

github

Committed by liran-funaro

Commit Message

[loadgen] Remove the workload distribution

#### Type of change

- Improvement

#### Description

- The load generator's `Distribution` descriptor supported five variants
(`const`, `uniform`, `normal`, `bernoulli`, `discrete`), but only `const`
was ever used. Load generation holds each parameter at a fixed value so
results are deterministic and comparable across runs, so the unused
variants only added config surface, sample-YAML documentation, generator
types, and tests with no realized benefit. This collapses `Distribution`
down to plain constant values.

#### Changes

- Delete `distributions.go` and the orphaned
`Const`/`FloatToInt`/`FloatToPositiveInt`/`FloatToBoolean` generators;
`MultiGenerator.Count` is now a plain `int`.
- Replace the `*Distribution` profile fields with plain scalars:
read/read-write/blind-write counts and query size become `uint32`, the
minimal invalid-keys portion becomes `Probability`, and the dependency
gap becomes `uint64` (min 1).
- Keep per-transaction conflict injection (invalid signatures and
dependency probability) via a small `bernoulliGenerator`
(`rnd.Float64() < p`) with identical semantics to the previous
Bernoulli-based path.
- Update the sample `loadgen.yaml` and the `loadgen_shared.yaml.tmpl`
config template to the plain-number syntax, plus the affected tests.

#### Related issues

- Resolves #682

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

22 of 22 new or added lines in 6 files covered. (100.0%)

27 existing lines in 9 files now uncovered.

10344 of 11295 relevant lines covered (91.58%)

35694.13 hits per line