liran-funaro / fabric-x-committer / 30002056381
91%
main: 92%

LAST BUILD BRANCH: loadgen-config-cleanup
DEFAULT BRANCH: main
Ran
Jobs 3
Files 128
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.296%. First build
30002056381

push

github

liran-funaro 
[loadgen] Consolidate workload config into TransactionProfile

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

Consolidate the loadgen workload config ahead of the index-addressable workload change;
no behavior change:

- Fold `key.size` (`KeyProfile`) into `TransactionProfile.KeySize`; delete `KeyProfile`.
- Fold `invalid-signatures` and `dependencies` into `TransactionProfile`; delete
  `ConflictProfile`. `DependencyDescription` and the dependency-conflict machinery
  (`dependenciesModifier`) are unchanged — only their config home moves.
- Inline invalid-signature stamping into the generator and drop `signTxModifier`; the
  per-worker bernoulli decision and dummy endorsement are unchanged. The generic
  `Modifier` mechanism stays (still used by `dependenciesModifier`).
- Move `key-size`, `invalid-signatures`, and `dependencies` under `transaction` in the
  config sample and template.

#### Additional details (Optional)

The generation seed order is preserved (the inlined invalid-signature RNG consumes the
seed where `signTxModifier` did), so the generated workload is byte-identical to before.
The coordinator's BenchmarkDependencyGraph is unchanged except for the moved field
reference (`p.Conflicts.Dependencies` -> `p.Transaction.Dependencies`).

Verified: `go build ./...`, `go vet`, `make lint-go` (0 issues), and the affected unit
tests (`loadgen/workload` incl. the dependency/modifier/invalid-signature tests, and
`cmd/config` loadgen decode/validation/env-override).

#### Related issues

- resolves #698

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

10279 of 11259 relevant lines covered (91.3%)

34723.36 hits per line

Jobs
ID Job ID Ran Files Coverage
1 unit-test - 30002056381.1 93
84.49
 GitHub Action Run
2 core-db-test - 30002056381.2 98
45.86
 GitHub Action Run
3 db-test - 30002056381.3 128
79.39
 GitHub Action Run
Source Files on build 30002056381