DanGould / rust-payjoin

85%

master: 85%

LAST BUILD ON BRANCH receiver-fallback

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• 24-name-audit
• 402-ref-audit
• 465-rm-relay-from-session-ctx
• access-control
• access-control-v2
• add-agents-md
• add-navigability-signposts
• additive-cli-features
• additive-danger-local-https
• ai-disclosure
• arc-sc
• async-standup-v2
• avoid-uih-naming
• bump-ohttp-relay-0.0.10
• bump-payjoin-0-21
• bump-payjoin-0.24.0
• bump-payjoin-cli-0-1-0
• bump-payjoin-directory-0.0.2
• check-fetch-status
• check-independent-features
• coderabbit-refine-exceptions
• coderabbit-review-drafts
• coderabbit-strip-noise
• complete-intourl
• contributing-readme
• dart-fetch-ohttp-keys
• demo-sender-fallback
• directory-mod
• doc-contrib-test
• dont-set-path
• dry-run/standup-comment-trigger
• ensure-no-original-psbt-keypath
• errant-url-endpoint
• explicit-err-conversions
• feat/1314
• feat/async-standup
• feat/standup-comment-trigger
• ffi-msrv-1.85.0
• fix-dlh
• fix-flaky-prune-test
• fix-output-substitution-import
• fix-send-resume
• fix-standup-syntax
• fix-test-flakiness
• fix-uri-ext-case
• fix/402-ref-audit
• fix/402-typestate-docs
• fix/794-msrv-clippy
• fix/cli-println-bip78-terminology
• fix/devshell-treefmt
• handle-post-err
• handle-recv-contribution-err-as-unavailable
• handle-v2-error
• handle-v2-error-generic
• hide-danger-local-https
• hide-pr-template-checklist
• inmemory-persister-single-owner
• into-url
• json-error
• lib-docs
• lint-1.85.0
• lint-docs
• master
• min-feerate-broadcast
• moddocs
• no-uni-mod-distinction
• ohttp-fallback
• ohttp-relay-intourl
• ohttp-reqs-refactor
• one-expiry-error
• only-try-preserving-privacy
• overnight/issue-1016
• overnight/issue-1258
• overnight/issue-1274
• overnight/issue-855
• payjoin-0.21.0
• payjoin-0.22.0
• payjoin-0.23.0
• payjoin-0.24.0
• payjoin-0.25.0
• payjoin-1.0.0-rc.0
• payjoin-1.0.0-rc.1
• payjoin-1.0.0-rc.2
• payjoin-directory-0-0-1
• payjoin-directory-0.0.2
• payjoin-mailroom-0.1.0
• payjoin-test-utils-0.0.0
• persist-ohttp-keys
• persist-payjoin
• persister-cleanup-1519
• pjos-to-0
• poll-no-pause
• pr-checklist
• prepare-psbt-by-copy
• propagate-config-err
• receive-error-heirarchy
• receiver-fallback
• recv-err
• recv-state-transition-objects
• refactor-receiver
• refactor-sender
• refactor-wantsfeerange
• reply-json
• req-impl-visibility
• seal-state-trait
• sep-receive-errors
• separate-receive
• separate-send-errors
• separate-send-versions-p1
• separate-send-versions-p2-v2
• service-docker-compose
• service-multi-listener
• session4/issue-1227
• session4/issue-1276
• session4/issue-1300
• session4/issue-1374
• session4/issue-749
• session4/standup-v2
• session4/unify-short-id
• split-v1-psbt-contexts
• test-utils
• test-utils-no-bitcoind
• test-utils-redis-follow
• uniform-ohttp-payloads
• update-bip78
• url-no-idna
• v1-data-minimization
• v1-feature-flag
• v1-v2
• v1context-visibility
• workflow-build-deps

Build # 25547534759

Build Type

push

github

Committed by DanGould

Commit Message

Disambiguate session IDs with s/r prefix

Sender and receiver session ids auto-increment per table, so
`send_sessions.id = 1` and `recv_sessions.id = 1` routinely coexist.
The previous `payjoin-cli fallback <i64>` dispatcher consulted the
sender table first, then the receiver table, then erred. A user who
meant their receive session 1 silently got their send session 1
fallen-back, broadcasting the wrong original.

Require an authoritative side prefix on every fallback invocation:
`s<n>` for sender, `r<n>` for receiver. Bare numeric input is rejected
with a usage error that names the expected format. The dispatcher
matches on the prefix; no table-existence guess is involved.

Introduce a small `SessionRef` enum with `FromStr` + `Display`
(round-trips, rejects bare numeric, prefix-only, unknown prefix,
negative, internal whitespace, overflow). Wire it through `App::fallback`
on both v1 and v2, and through every operator-visible display site that
currently prints a bare numeric id: `history` rows, the send-payjoin
failure/interrupt hints, the `fallback_sender` / `fallback_receiver`
status messages, and the `process_sender_session` end-of-session hint.
Drop `Database::has_send_session` / `has_recv_session`; they were added
in the previous commit purely to power auto-dispatch and have no other
callers.

Update both fallback e2e tests to feed the prefixed ref.

Without this, every operator with one of each session role open is
one typo away from broadcasting the wrong original.

Coverage Stats

80 of 99 new or added lines in 4 files covered. (80.81%)

11597 of 13633 relevant lines covered (85.07%)

401.67 hits per line