3984

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
3984	master	[#795] EditPersonDescriptor: update methods to perform defensive copy getTags() returns the same set of tags stored by this object, while setTags(Set<Tag>) assigns the given Set<Tag> to its field without defensive copy. Callers can modify th...	push	18 Jan 2018 01:24PM UTC	web-flow	travis-ci	pending completion set done
3983	master	[#751] Edit Make Person immutable (#765) Person is mutable. This is bad as: 1. It is easy to break invariants by mutating an existing object which we do not own. 2. No code uses Person’s setter methods. By making Person immutable, we can...	push	18 Jan 2018 01:16PM UTC	web-flow	travis-ci	pending completion set done
3982	master	Model: Add deleteTag(Tag) The Model API does not expose a way to delete a particular Tag entirely from the AddressBook (i.e. removing the Tag from all Persons and purging the Tag in the AddressBook's tag list). Let's add Model#deleteTag(Tag).	Pull #790	18 Jan 2018 07:57AM UTC	web-flow	travis-ci	pending completion set done
3980	master	UndoableCommand: Update redo() to restore previous view before executing The method undo() sets the Addressbook view to show all persons after restoring the Addressbook state. This could cause the redoing of commands that are index-based such a...	Pull #792	17 Jan 2018 09:05AM UTC	web-flow	travis-ci	pending completion set done
3976	master	Add documentation on how to set up and use Coveralls There is no documentation on how to set up Coveralls. With a detailed explanation, new developers can set up Coveralls easily and receive coverage report after each Travis build. Let's add d...	push	17 Jan 2018 06:52AM UTC	Zhiyuan-Amos	travis-ci	pending completion set done
3978	master	Person: Remove copy constructor This copy constructor existed for the purpose of defensive copying. Person is immutable. There is no need for defensive copying. Let’s remove it. Some methods depended on Person's copy constructor to throw NullP...	Pull #765	17 Jan 2018 05:42AM UTC	web-flow	travis-ci	pending completion set done
3977	master	EditPersonDescriptor#getTags(): return unmodifiable set getTags() returns the same set of tags stored by EditPersonDescriptor. Callers can modify the state of the Set<Tag> externally, thus breaking EditPersonDescriptor’s encapsulation. Let’s te...	Pull #795	18 Jan 2018 01:16PM UTC	web-flow	travis-ci	pending completion set done
3975	master	EditPersonDescriptor#getTags(): return unmodifiable set getTags() returns the same set of tags stored by EditPersonDescriptor. Callers can modify the state of the Set<Tag> externally, thus breaking EditPersonDescriptor’s encapsulation. Let’s te...	Pull #795	16 Jan 2018 02:32PM UTC	web-flow	travis-ci	pending completion set done
3973	master	EditPersonDescriptor#getTags(): return unmodifiable set getTags() returns the same set of tags stored by EditPersonDescriptor. Callers can modify the state of the Set<Tag> externally, thus breaking EditPersonDescriptor’s encapsulation. Let’s te...	Pull #795	16 Jan 2018 02:22PM UTC	web-flow	travis-ci	pending completion set done
3972	master	UndoableCommand: Update redo() to restore previous view before executing The method undo() sets the Addressbook view to show all persons after restoring the Addressbook state. This could cause the redo() of Commands that are index-based such as ...	Pull #792	16 Jan 2018 07:37AM UTC	web-flow	travis-ci	pending completion set done
3971	master	UndoableCommand: Update redo() to restore previous view before executing The method undo() sets the Addressbook view to show all persons after restoring the Addressbook state. This could cause the redo() of Commands that are index-based such as ...	Pull #792	16 Jan 2018 07:32AM UTC	web-flow	travis-ci	pending completion set done
3970	master	UndoableCommand: Update undo() to restore previous view The method undo() sets the Addressbook view to show all persons after restoring the Addressbook state. This could cause the redo() of Commands that are index-based such as DeleteCommand and...	Pull #792	16 Jan 2018 07:18AM UTC	web-flow	travis-ci	pending completion set done
3969	master	Person: Remove copy constructor This copy constructor existed for the purpose of defensive copying. Person is immutable. There is no need for defensive copying. Let’s remove it. Some methods depended on Person's copy constructor to throw NullP...	Pull #765	16 Jan 2018 02:18AM UTC	web-flow	travis-ci	pending completion set done
3967	master	EditPersonDescriptor#getTags(): Return unmodifiable set getTags() returns the same set of tags stored by EditPersonDescriptor. Callers can modify the state of the Set<Tag> externally, thus breaking EditPersonDescriptor’s encapsulation. Let’s te...	Pull #795	15 Jan 2018 02:18PM UTC	web-flow	travis-ci	pending completion set done
3966	master	UndoableCommand: Update `redo()` restore previous view before executing The method `undo()` sets the `Addressbook` view to show all persons after restoring the `Addressbook` state. This leads to `redo()` potentially executing its command on the ...	Pull #792	14 Jan 2018 04:51PM UTC	web-flow	travis-ci	pending completion set done

← Previous
1
2
…
64
65
66
67
68
69
70
71
72
…
77
78
Next →