se-edu / addressbook-level4 / 4018

Builds Branch Commit Type Ran Committer Via Coverage
4018 master XmlSerializableAddressBook#getPersonList(): Add non-null filter The lambda expression in XmlSerializableAddressBook#getPersonList() adds a null value to the person list if an IllegalValueException is caught. This causes the program to crash when... Pull #806 web-flow travis-ci pending completion   set done
4017 master UniquePersonList#setPersons(List<Person>): refactor verbose loop The for loop in UniquePersonList#setPersons(List<Person>) is verbose and it can be simplified. Since lambda expression cannot handle exceptions, this loop cannot be replaced by a... Pull #805 web-flow travis-ci pending completion   set done
4016 master Checkstyle: remove unnecessary properties with default values Several properties in checkstyle.xml are using default values. According to the Checktyle documentation, these are not required if the default value is satisfactory. Let's remove t... Pull #802 web-flow travis-ci pending completion   set done
4015 master UndoableCommand: Update redo() to restore previous view before executing The method undo() sets the Model view to show all persons after restoring the Addressbook state. As a result, redoing of index-based commands such as DeleteCommand and Edit... Pull #792 web-flow travis-ci pending completion   set done
4014 master UiManager: Delete duplicate code UiManager calls primaryStage.setTitle(). This is called by MainWindow as well. The setting of the title should not be the job of UiManager as different Windows may have different titles; each Window should be res... Pull #804 web-flow travis-ci pending completion   set done
4013 master UniquePersonList: refactor verbose loop in setPersons The for loop in UniquePersonList#setPersons is verbose. Since lambda expression cannot handle exceptions, this loop cannot be replaced by a lambda expression and needs to be simplified inste... Pull #805 web-flow travis-ci pending completion   set done
4012 master Merge branch 'UiManager-Delete_Duplicate_Code' of https://github.com/Rinder5/addressbook-level4 into UiManager-Delete_Duplicate_Code Pull #804 web-flow travis-ci pending completion   set done
4011 master UiManager: Delete duplicate code UiManager calls primaryStage.setTitle(). This is called by MainWindow as well. The setting of the title should not be the job of UiManager as different Windows may have different titles; each Window should be res... Pull #804 web-flow travis-ci pending completion   set done
4010 master <a href="https://github.com/se-edu/addressbook-level4/commit/62b4243fd">Revert &quot;UiManager: Delete duplicate code&quot; This reverts commit </a><a class="double-link" href="https://github.com/se-edu/addressbook-... Pull #804 web-flow travis-ci pending completion   set done
4009 master Replace verbose loops with lambda expressions Many loops are verbose. This leads to longer lines of code that are not concise and clean. Let's replace these verbose loops with lambda expressions to improve code quality. Pull #805 web-flow travis-ci pending completion   set done
4008 master XmlSerializableAddressBook: Add non-null filter in getPersonList() The lambda expression in getPersonList() adds a null value to the person list if an IllegalValueException is caught. This leads to NullPersonException to be thrown in other place... Pull #806 web-flow travis-ci pending completion   set done
4007 master AddressBook: Inline setter methods setPersons(...) and setTags(...) are only used internally. It is unnecessary have the logic of setting persons and tags to be extracted as separate setter methods, since their logic aren’t meant to be used by o... Pull #794 web-flow travis-ci pending completion   set done
4006 master Checkstyle: remove unnecessary properties with default values Several properties in checkstyle.xml are using default values. According to the Checktyle documentation, these are not required if the default value is satisfactory. Let's remove t... Pull #802 web-flow travis-ci pending completion   set done
4005 master UiManager: Delete duplicate code UiManager calls primaryStage.setTitle(). This is called by MainWindow as well. The setting of the title should not be the job of UiManager as different Windows may have different titles; each Window should be res... Pull #804 web-flow travis-ci pending completion   set done
4004 master Checkstyle: remove unnecessary properties with default values Several properties in checkstyle.xml have default values. According to the Checktyle documentation, these are not required if the default value is satisfactory. Let's remove these ... Pull #802 web-flow travis-ci pending completion   set done