4034

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
4034	master	UiManager: delete duplicate code Both UiManager and MainWindow call primaryStage.setTitle(). The setting of the title should not be the job of UiManager as different Windows may have different titles; each Window should be responsible for assign...	push	24 Jan 2018 01:06PM UTC	Zhiyuan-Amos	travis-ci	pending completion set done
4033	master	Model: Add deleteTag(Tag) The Model API does not expose a way to delete a particular Tag entirely from the AddressBook (i.e. removing the Tag from all Persons and purging the Tag in the AddressBook's tag list). Let's add Model#deleteTag(Tag).	Pull #790	13 Feb 2018 03:47PM UTC	web-flow	travis-ci	pending completion set done
4032	master	EditCommand#preprocessUndoableCommand(): find and store personToEdit EditCommand only stores the index of the personToEdit in its current filteredPersonList. As a result, redoing of EditCommand will be executed on the incorrect person due to dif...	Pull #792	23 Jan 2018 12:52PM UTC	web-flow	travis-ci	pending completion set done
4031	master	EditCommand#preprocessUndoableCommand(): find and store personToEdit EditCommand only stores the index of the personToEdit in its current filteredPersonList. As a result, redoing of EditCommand will be executed on the incorrect person due to dif...	Pull #792	23 Jan 2018 12:48PM UTC	web-flow	travis-ci	pending completion set done
4030	master	UiManager: delete duplicate code Both UiManager and MainWindow call primaryStage.setTitle(). The setting of the title should not be the job of UiManager as different Windows may have different titles; each Window should be responsible for assign...	Pull #804	23 Jan 2018 05:23AM UTC	web-flow	travis-ci	pending completion set done
4028	master	EditCommand#preprocessUndoableCommand(): Find and store personToEdit EditCommand only stores the index of the personToEdit in its current filteredPersonList. As a result, redoing of EditCommand will be executed on the incorrect person due to dif...	Pull #792	22 Jan 2018 08:22PM UTC	web-flow	travis-ci	pending completion set done
4027	master	EditCommand#preprocessUndoableCommand(): Find and store personToEdit EditCommand only stores the index of the personToEdit in its current filteredPersonList. As a result, redoing of EditCommand will be executed on the incorrect person due to dif...	Pull #792	22 Jan 2018 08:10PM UTC	web-flow	travis-ci	pending completion set done
4026	master	EditCommand#preprocessUndoableCommand(): Find and store personToEdit EditCommand only stores the index of the personToEdit in its current filteredPersonList. As a result, redoing of EditCommand will be executed on the incorrect person due to dif...	Pull #792	22 Jan 2018 08:05PM UTC	web-flow	travis-ci	pending completion set done
4025	master	EditCommand#preprocessUndoableCommand(): Find and store personToEdit EditCommand only stores the index of the personToEdit in its current filteredPersonList. As a result, redoing of EditCommand will be executed on the incorrect person due to dif...	Pull #792	22 Jan 2018 07:57PM UTC	web-flow	travis-ci	pending completion set done
4024	master	EditCommand#preprocessUndoableCommand(): Find and store personToEdit EditCommand only stores the index of the personToEdit in its current filteredPersonList. As a result, redoing of EditCommand will be executed on the incorrect person due to dif...	Pull #792	22 Jan 2018 07:54PM UTC	web-flow	travis-ci	pending completion set done
4023	master	XmlSerializableAddressBook#getPersonList(): Add non-null filter The lambda expression in XmlSerializableAddressBook#getPersonList() adds a null value to the person list if an IllegalValueException is caught. As callers do not expect null values ...	Pull #806	22 Jan 2018 04:30PM UTC	web-flow	travis-ci	pending completion set done
4022	master	PersonCard: Add colors to tag labels The tags are all displayed with the same color. It is hard to differentiate between tags visually across contacts. For example, it is hard to visually group all contacts tagged with "colleague". It is also ha...	Pull #798	22 Jan 2018 04:11AM UTC	web-flow	travis-ci	pending completion set done
4021	master	Model: Add deleteTag(Tag) The Model API does not expose a way to delete a particular Tag entirely from the AddressBook (i.e. removing the Tag from all Persons and purging the Tag in the AddressBook's tag list). Let's add Model#deleteTag(Tag).	Pull #790	22 Jan 2018 03:34AM UTC	web-flow	travis-ci	pending completion set done
4020	master	UniquePersonList#setPersons(List<Person>): refactor verbose loop The for loop in UniquePersonList#setPersons(List<Person>) is verbose and it can be simplified. Since lambda expressions cannot handle exceptions, this loop cannot be replaced by ...	Pull #805	21 Jan 2018 12:13PM UTC	web-flow	travis-ci	pending completion set done
4019	master	XmlSerializableAddressBook#getPersonList(): Add non-null filter The lambda expression in XmlSerializableAddressBook#getPersonList() adds a null value to the person list if an IllegalValueException is caught. This causes the program to crash when...	Pull #806	20 Jan 2018 03:10PM UTC	web-flow	travis-ci	pending completion set done

← Previous
1
2
…
61
62
63
64
65
66
67
68
69
…
77
78
Next →