se-edu / addressbook-level4 / 4435

Builds Branch Commit Type Ran Committer Via Coverage
4435 master README.adoc: update JUnit4 to JUnit5 in Acknowledgements README.adoc references JUnit4 in its Acknowledgements. This is outdated as AddressBook-level4 now uses JUnit5. Let's update JUnit4 to JUnit5 Pull #870 web-flow travis-ci pending completion   set done
4434 master PersonListPanelTest: fix flaky test (#863) PersonListPanelTest#createBackingList(int) is used by performanceTest(). It logs the time taken for execution of this method and throws AssertionError if it takes too long to execute. performanceTe... push web-flow travis-ci pending completion   set done
4433 master UsingCheckstyle.adoc: update documentation to include clicking `Apply` Clicking the Apply button after configuring the Checkstyle version is not explicitly specified in documentation. The Checkstyle-IDEA plugin will continue to use the previous ... Pull #875 web-flow travis-ci pending completion   set done
4432 master README.adoc: update JUnit4 to JUnit5 in Acknowledgements README.adoc references JUnit4 in its Acknowledgements. This is outdated as AddressBook-level4 now uses JUnit5. Let's update JUnit4 to JUnit5 Pull #870 web-flow travis-ci pending completion   set done
4431 master ConfigUtilTest: update to use platform-independent path for preferences ConfigUtilTest#getTypicalConfig() uses a path for the user preference file that is only meant for the Window's operating system. This should not be the case as AddressBook ... Pull #866 web-flow travis-ci pending completion   set done
4430 master DeveloperGuide: update section of UndoRedoStack to AddressBookCareTaker We previous have UndoRedoStack which stores the UndoableCommands in LogicManager. Since UndoRedoStack has been updated to AddressBookCareTaker which stores ReadOnlyAddressBo... Pull #861 web-flow travis-ci pending completion   set done
4425 master DarkTheme.css: update styleClass to stack-pane CommandBox.fxml and StatusBarFooter.fxml both use StackPane as the root node. However, both use 'anchor-pane' as their styleClass. 'anchor-pane' style class is not used elsewhere in the code base. L... Pull #870 web-flow travis-ci pending completion   set done
4427 master FileUtil: remove unsued methods After refactoring the codebase to use java.nio.file for file/path handling, several methods become unused. Following that, FileUtilTest would be testing unused methods. For code quality purposes, unused methods ... Pull #866 web-flow travis-ci pending completion   set done
4426 master Person: add an equality check for tags The equality methods that check for both identity and data fields, Person#equals(Object) and PersonCardHandle#equals(Person), checks if all fields of the Person except tags are identical. Since these metho... Pull #844 web-flow travis-ci pending completion   set done
4424 master Person: add equality method for identity fields Person class contains only one equality method Person#equals(Object) which checks if all fields of the Person except tags are identical. Two Persons of the same name that have at least one other e... Pull #844 web-flow travis-ci pending completion   set done
4423 master FileUtil: remove unsued methods and FileUtilTest After refactoring the codebase to use java.nio.file for file/path handling, several methods become unused. Following that, FileUtilTest would be testing unused methods. For code quality purposes... Pull #866 web-flow travis-ci pending completion   set done
4420 master DarkTheme.css: update styleClass to stack-pane CommandBox.fxml and StatusBarFooter.fxml both use StackPane as the root node. However, both use 'anchor-pane' as their styleClass. 'anchor-pane' style class is not used elsewhere in the code base. L... Pull #870 web-flow travis-ci pending completion   set done
4419 master UsingCheckstyle.adoc: update documentation to include clicking `Apply` We do not specify that clicking `Apply` is required after selecting the Checkstyle version before choosing the checkstyle file. If not clicked, Checkstyle will use the previou... Pull #875 web-flow travis-ci pending completion   set done
4418 master PersonListPanelTest#performanceTest(): update header comment The header comment does not clearly specify what "too long" exactly refers to. Let's make the header comment clearer by specifying that this test should only take less than CARD_CREATI... Pull #863 web-flow travis-ci pending completion   set done
4416 master [#753] AddressBook: remove master tag list (#825) We keep track of a master tag list which holds all the tags in AddressBook. The tag list is not implemented correctly. The original intention was for tags in Person to point to the tags in t... push web-flow travis-ci pending completion   set done