se-edu / addressbook-level4 / 4415

Builds Branch Commit Type Ran Committer Via Coverage
4415 master UsingCheckstyle.adoc: update documentation to include clicking `Apply` We do not specify that clicking `Apply` is required after selecting the Checkstyle version before choosing the checkstyle file. If not clicked, Checkstyle will use the previou... Pull #875 web-flow travis-ci pending completion   set done
4413 master [#685] TypicalPersons: Unintuitive interaction with PersonBuilder (#845) If no tag is set when constructing a new Person using PersonBuilder, the tag "friends" is added to the Person by default. This should not happen as tags are optional. A... push web-flow travis-ci pending completion   set done
4412 master PersonBuilder: remove default tag If no tag is set when constructing a new Person using PersonBuilder, the tag "friends" is added to the Person by default. This should not happen as tags are optional. As a result, all Persons in TypicalPersons h... Pull #845 web-flow travis-ci pending completion   set done
4411 master PersonListPanelTest#performanceTest(): update header comment The header comment does not clearly specify what "too long" exactly refers to. Let's make the header comment clearer by specifying that this test should only take less than CARD_CREATI... Pull #863 web-flow travis-ci pending completion   set done
4410 master DeveloperGuide: update sections on UndoRedoStack UndoRedoStack previously stores the UndoableCommands, and was in LogicManager. Since UndoRedoStack has been updated to store ReadOnlyAddressBook and has been moved to Model instead, the sections o... Pull #861 web-flow travis-ci pending completion   set done
4409 master PersonBuilder: remove default tag If no tag is set when constructing a new Person using PersonBuilder, the tag "friends" is added to the Person by default. This should not happen as tags are optional. As a result, all Persons in TypicalPersons h... Pull #845 web-flow travis-ci pending completion   set done
4408 master DarkTheme.css: update styleClass to stack-pane Both fxml files use StackPane as the root node. However, both use 'anchor-pane' as their styleClass. 'anchor-pane' style class is not used elsewhere in the code base. Let's rename 'anchor-pane' to '... Pull #870 web-flow travis-ci pending completion   set done
4406 master DeveloperGuide: update sections on UndoRedoStack UndoRedoStack previously stores the UndoableCommands, and was previously in LogicManager. Since UndoRedoStack has been updated to store ReadOnlyAddressBook and has been moved to Model instead, the... Pull #861 web-flow travis-ci pending completion   set done
4405 master DeveloperGuide: update sections on UndoRedoStack. UndoRedoStack previously stores the UndoableCommands, and was previously in LogicManager. Since UndoRedoStack has been updated to store ReadOnlyAddressBook and has been moved to Model instead, th... Pull #861 web-flow travis-ci pending completion   set done
4398 master Simplify PersonListPanelTest#createBackingList(int) This method is used by performanceTest(). It logs the time taken for execution of this method and throws AssertionError if it takes too long to execute. performanceTest() should only concern it... Pull #863 web-flow travis-ci pending completion   set done
4397 master Developer guide: update model component section AddressBook previously had a UniqueTagList linked to it, which was reflected in the model component diagram. Since AddressBook does not use a master tag list anymore, the model component diagram is... Pull #825 web-flow travis-ci pending completion   set done
4396 master PersonBuilder: remove default tag If no tag is set when constructing a new Person using PersonBuilder, the tag "friends" is added to the Person by default. This should not happen as tags are optional. As a result, all Persons in TypicalPersons h... Pull #845 web-flow travis-ci pending completion   set done
4394 master Gradle: upgrade to JUnit5 Gradle uses JUnit 4.12 for testing which is an older version of JUnit. Let's upgrade to JUnit 5. To use JUnit 5, we need to add in additional dependencies junit-jupiter-api and junit-jupiter-engine. Junit-jupiter-engine... push Zhiyuan-Amos travis-ci pending completion   set done
4393 master FileUtil: remove unsued methods and FileUtilTest After refactoring the codebase to use java.nio.file for file/path handling, several methods become unused. Following that, FileUtilTest would be testing unused methods. For code quality purposes... Pull #866 web-flow travis-ci pending completion   set done
4389 master Merge branch 'master' into #824 Pull #854 web-flow travis-ci pending completion   set done