JuliaLang / julia
77%

DEFAULT BRANCH: master
Repo Added
Files 350
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x

coverage: 76.686% (-0.06%) from 76.749%
1408

push

buildkite

web-flow 
Move thunk and export evaluation out of `jl_toplevel_eval_flex` (#60528)

Deconstructing `jl_toplevel_eval_flex` to help with JuliaLowering integration
and to further disentangle top level evaluation from `Expr` and from the code in
toplevel.c:

### `jl_eval_thunk`: C API for CodeInfo evaluation without Expr

Separate CodeInfo evaluation out of `jl_toplevel_eval_flex` into
`jl_eval_thunk` so that `CodeInfo` can become the basic unit of toplevel
evaluation rather than `Expr`.

The latest world age set and restore now moves entirely into `jl_eval_thunk` as
`jl_toplevel_eval_flex` no longer modifies the task's world age. The world age
set and restore inside `jl_eval_thunk` needs to moves outward so that it wraps
around the calls to `jl_resolve_definition_effects_in_ir` which interprets some
limited top level expressions for the argument types foreigncall, etc.
(Previously the world age was updated to the latest in functions which call
`jl_toplevel_eval_flex` so resolving definition effects happened to work.)

`jl_filename` and `jl_lineno` are also set from `jl_eval_thunk` using the same
debuginfo used within codegen so that deprecation binding errors and
`jl_fprint_critical_error` can contain the approximate line number.

### `jl_module_public` API for declaring symbols public/exported

Move public/export batching out of `jl_toplevel_eval_flex` and into a C runtime
function `jl_module_public` which can be called without using eval and without
constructing an Expr.

### Side quest: Fix GC rooting in `jl_declare_constant_val2`

Various seemingly-unrelated changes in `jl_toplevel_eval_flex`
mysteriously cause the static analyzer to see a rooting problem in
`jl_declare_constant_val2`: The `val` argument is currently declared
JL_MAYBE_UNROOTED, but we call JL_LOCK without rooting it.

I've done the simplest fix here which is to root `val` inside
`jl_declare_constant_val2`. An alternative would be to remove the
`JL_MAYBE_UNROOTED` annotation which could be an ... (continued)

62680 of 81736 relevant lines covered (76.69%)

23380003.16 hits per line

Relevant lines Covered
81736 RELEVANT LINES 62680 COVERED LINES
23380003.16 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
1408 master Move thunk and export evaluation out of `jl_toplevel_eval_flex` (#60528) Deconstructing `jl_toplevel_eval_flex` to help with JuliaLowering integration and to further disentangle top level evaluation from `Expr` and from the code in toplevel.c: #... push web-flow buildkite
76.69
1407 master Fix `@test_loweringerror` macro to return the `code` correctly. (#60598) for the PR #60556, the macro returns nothing so nothing has happened. --------- Co-authored-by: Claire Foster <aka.c42f@gmail.com> push web-flow buildkite
76.74
1562 main Fix `@test_loweringerror` macro to return the `code` correctly. (#60598) for the PR #60556, the macro returns nothing so nothing has happened. --------- Co-authored-by: Claire Foster <aka.c42f@gmail.com> push web-flow buildkite
76.75
1561 master curl: Update to 8.18 (#60636) Pull #511 web-flow buildkite
76.66
1405 master Add `@stm` "SyntaxTree match" macro (#60475) push web-flow buildkite
76.65
1404 master Add `@stm` "SyntaxTree match" macro (#60475) push web-flow buildkite
76.72
1403 master [JuliaLowering] Implement flisp-compatible Box optimization (#60567) This PR implements `_optimize_lambda_vars!` which identifies captured local variables that can avoid `Core.Box` allocation. Essentially a direct port of the existing `lambda-opt... push web-flow buildkite
76.68
1560 main avoid some more `Core.Box` in Base and SharedArrays (#60599) push web-flow buildkite
76.71
1402 master Markdown: test different flavors, roundtripping (#60603) Run CommonMark spec tests against all supported Markdown flavors. This way we may notice regressions in any flavor, not just the default one. Of course the different flavors have different... push web-flow buildkite
76.68
1559 92524901548ddad4a7529f00be47d2e1d9d80bae [JuliaLowering] Fix-up always-defined check in `is_valid_body_ir_argument` (#60602) This was slightly mis-translated from the flisp side: ```scheme (define (valid-body-ir-argument? aval) (or (valid-ir-argument? aval) (and (sym... Pull #366 web-flow buildkite
76.63
See All Builds (6402)