JuliaLang / julia
87%

DEFAULT BRANCH: master
Repo Added
Files 330
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 86.907% (+0.004%) from 86.903%
#37954

push

local

web-flow 
Make world-age increments explicit (#56509)

This PR introduces a new, toplevel-only, syntax form `:worldinc` that
semantically represents the effect of raising the current task's world
age to the latest world for the remainder of the current toplevel
evaluation (that context being an entry to `eval` or a module
expression). For detailed motivation on why this is desirable, see
#55145, which I won't repeat here, but the gist is that we never really
defined when world-age increments and worse are inconsistent about it.
This is something we need to figure out now, because the bindings
partition work will make world age even more observable via bindings.

Having created a mechanism for world age increments, the big question is
one of policy, i.e. when should these world age increments be inserted.

Several reasonable options exist:
1. After world-age affecting syntax constructs (as proprosed in #55145)
2. Option 1 + some reasonable additional cases that people rely on
3. Before any top level `call` expression
4. Before any expression at toplevel whatsover

As an example, case, consider `a == a` at toplevel. Depending on the
semantics that could either be the same as in local scope, or each of
the four world age dependent lookups (three binding lookups, one method
lookup) could (potentially) occur in a different world age.

The general tradeoff here is between the risk of exposing the user to
confusing world age errors and our ability to optimize top-level code
(in general, any `:worldinc` statement will require us to fully
pessimize or recompile all following code).

This PR basically implements option 2 with the following semantics:

1. The interpreter explicit raises the world age only at `:worldinc`
exprs or after `:module` exprs.
2. The frontend inserts `:worldinc` after all struct definitions, method
definitions, `using` and `import.
3. The `@eval` macro inserts a worldinc following the call to `eval` if
at toplev... (continued)

17 of 18 new or added lines in 5 files covered. (94.44%)

124 existing lines in 8 files now uncovered.

65236 of 75064 relevant lines covered (86.91%)

9581733.99 hits per line

Relevant lines Covered
75064 RELEVANT LINES 65236 COVERED LINES
9581733.99 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#37954 master Make world-age increments explicit (#56509) This PR introduces a new, toplevel-only, syntax form `:worldinc` that semantically represents the effect of raising the current task's world age to the latest world for the remainder of the current to... push web-flow local
86.91
#37953 master codegen: manually restore `ct->scope` when no exception handler is emitted (#56612) This fixes a bug introduced by #55907, which was neglecting that it's possible for `EnterNode` to have no `catch` destination and still have a scope. This ca... push web-flow local
86.9
#37952 master optimize `abstract_call_gf_by_type` (#56572) Combines many allocations into one and types them for better inference push web-flow local
86.9
#37951 master Move Compiler <-> OpaqueClosure interface code to Compiler (#56576) After the excision, it is no longer permissable for Base to have `Compiler` data structures in arguments of methods it defines. To comply with this restriction, move the functi... push web-flow local
86.47
#37950 master infer more completely everything that the optimizer/codegen requires (#56565) Inlining wants to know information about every isa_compileable_sig method as well as everything it might consider inlining (which is almost the same thing). So even i... push web-flow local
86.91
#37949 master Merge Compiler.isready and Base.isready (#56536) These didn't get merged when the Compiler moved out, because the Base function doesn't get defined until very late in the build process. However, they are semantically the same, so merge their me... push web-flow local
87.48
#37948 master Make Compiler an independent package (that lives in the julia repo) (#56409) This is a further extension to #56128 to make the compiler into a proper stdlib, useable outside of `Base` as `using Compiler` in the same way that `JuliaSyntax` works... push web-flow local
87.49
#37947 master add tip for module docstrings before load (#56445) push web-flow local
87.53
#37946 master Make build system respect `FORCE_COLOR` and `NO_COLOR` settings (#56346) Follow up to #53742, but for the build system. CC: @omus. push web-flow local
87.54
#37945 master InteractiveUtils: define `InteractiveUtils.@code_ircode` (#56390) push web-flow local
87.55
See All Builds (6058)