10
68%
master: 71%

Ran 17 Nov 2015 12:42PM UTC

Files 60

Run time 8s

Badge

Embed ▾

Committed 17 Nov 2015 12:34PM UTC coverage: 67.357%. First build

Job # TWISTED=Twisted==15.1.0

Build Type

push

travis-ci

Committed by

anadahz

Commit Message

fix 'Headers' object has not attribute 'getDiff' warning

This warning was reported by @anadahz in #401. I investigated: it turns
out that `headers_a` sometimes is Twisted's headers and sometimes is the
headers wrapper by OONI. The latter has `getDiff()` while the former
has not, hence the above mentioning warning arises.

It is beyond my understanding of how OONI works to figure out why sometimes
`headers_a` is of one type and sometimes is of another type.

Maybe @hellais knows why this is the case?

My empirical understanding of the matter (after running one whole deck) is
that `headers_b` is always the OONI wrapper and so always implements the
`getDiff()` function. Therefore, I fixed the issue by swapping `headers_a`
and `headers_b` in that piece of code.

Run Details

3415 of 5070 relevant lines covered (67.36%)

0.67 hits per line

TheTorProject / ooni-probe / 1281 / 10
68%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1281.10 (TWISTED=Twisted==15.1.0)

TheTorProject / ooni-probe / 1281 / 10 68% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1281.10 (TWISTED=Twisted==15.1.0)

TheTorProject / ooni-probe / 1281 / 10
68%
master: 71%

README BADGES
x