1281
68%
master: 71%

Ran 17 Nov 2015 12:37PM UTC

Jobs 14

Files 60

Run time 7min

Badge

Embed ▾

pending completion

Build # 1281

Build Type

push

travis-ci

Committed by

anadahz

Commit Message

fix 'Headers' object has not attribute 'getDiff' warning

This warning was reported by @anadahz in #401. I investigated: it turns
out that `headers_a` sometimes is Twisted's headers and sometimes is the
headers wrapper by OONI. The latter has `getDiff()` while the former
has not, hence the above mentioning warning arises.

It is beyond my understanding of how OONI works to figure out why sometimes
`headers_a` is of one type and sometimes is of another type.

Maybe @hellais knows why this is the case?

My empirical understanding of the matter (after running one whole deck) is
that `headers_b` is always the OONI wrapper and so always implements the
`getDiff()` function. Therefore, I fixed the issue by swapping `headers_a`
and `headers_b` in that piece of code.

Run Details

3426 of 5070 relevant lines covered (67.57%)

9.43 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1281.1 (TWISTED=Twisted==12.2)	17 Nov 2015 12:41PM UTC	60	67.36	Travis Job 1281.1
2	1281.2 (TWISTED=Twisted==12.3)	17 Nov 2015 12:38PM UTC	60	67.44	Travis Job 1281.2
3	1281.3 (TWISTED=Twisted==13.0)	17 Nov 2015 12:38PM UTC	60	67.34	Travis Job 1281.3
4	1281.4 (TWISTED=Twisted==13.1)	17 Nov 2015 12:37PM UTC	60	67.32	Travis Job 1281.4
5	1281.5 (TWISTED=Twisted==13.2)	17 Nov 2015 12:37PM UTC	60	67.32	Travis Job 1281.5
6	1281.6 (TWISTED=Twisted==14.0)	17 Nov 2015 12:39PM UTC	60	67.32	Travis Job 1281.6
7	1281.7 (TWISTED=Twisted==14.0.1)	17 Nov 2015 12:39PM UTC	60	67.32	Travis Job 1281.7
8	1281.8 (TWISTED=Twisted==14.0.2)	17 Nov 2015 12:44PM UTC	60	67.34	Travis Job 1281.8
9	1281.9 (TWISTED=Twisted==15.0.0)	17 Nov 2015 12:42PM UTC	60	67.36	Travis Job 1281.9
10	1281.10 (TWISTED=Twisted==15.1.0)	17 Nov 2015 12:42PM UTC	60	67.36	Travis Job 1281.10
11	1281.11 (TWISTED=Twisted==15.2.0)	17 Nov 2015 12:42PM UTC	60	67.36	Travis Job 1281.11
12	1281.12 (TWISTED=Twisted==15.2.1)	17 Nov 2015 12:44PM UTC	60	67.36	Travis Job 1281.12
13	1281.13 (TWISTED=Twisted==15.3.0)	17 Nov 2015 12:45PM UTC	60	67.36	Travis Job 1281.13
14	1281.14 (TWISTED=Twisted==15.4.0)	17 Nov 2015 12:44PM UTC	60	67.36	Travis Job 1281.14

Source Files on build 1281

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

TheTorProject / ooni-probe / 1281
68%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1281

TheTorProject / ooni-probe / 1281 68% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1281

TheTorProject / ooni-probe / 1281
68%
master: 71%

README BADGES
x