1
0%
master: 0%

Ran 17 Nov 2015 07:18AM UTC

Files 14

Run time 4s

Badge

Embed ▾

Committed 17 Nov 2015 07:11AM UTC coverage: 87.166% (-0.1%) from 87.268%

Job # 2.2.3, export RAILS_ENV=test, spec/dummy/Gemfile

Build Type

Pull #102

travis-ci

Committed by

ryanaip

Commit Message

Use data attrs when rendering react_component's

Client side rendering scripts do not get called when using the forward/back buttons with turbolinks, because turbolinks does not re-evaluate script tags when navigating through the history.

Instead of creating script tags throughout the page, instead use html elements with data attributes specifying each react component to be rendered, and iterate through all of those elements whenever the page loads.

This has the added benefit of removing global data variables from being set on the window object and simplifying the rendering code.

(Note that it will be possible to support turbolinks navigation with the still-on-master `data-turbolinks-eval=always` feature of turbolinks.  But this solution doesn't depend on that upgrade and is a bit cleaner anyway.)

Pull Request Pull Request #102: Use data attrs when rendering react_components instead of script tags

Coverage Stats

326 of 374 relevant lines covered (87.17%)

19.02 hits per line

shakacode / react_on_rails / 512 / 1
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 512.1 (2.2.3, export RAILS_ENV=test, spec/dummy/Gemfile)

shakacode / react_on_rails / 512 / 1 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 512.1 (2.2.3, export RAILS_ENV=test, spec/dummy/Gemfile)

shakacode / react_on_rails / 512 / 1
0%
master: 0%

README BADGES
x