shakacode / react_on_rails / 512

0%

Pull #102

travis-ci

Use data attrs when rendering react_component's

Client side rendering scripts do not get called when using the forward/back buttons with turbolinks, because turbolinks does not re-evaluate script tags when navigating through the history.

Instead of creating script tags throughout the page, instead use html elements with data attributes specifying each react component to be rendered, and iterate through all of those elements whenever the page loads.

This has the added benefit of removing global data variables from being set on the window object and simplifying the rendering code.

(Note that it will be possible to support turbolinks navigation with the still-on-master `data-turbolinks-eval=always` feature of turbolinks.  But this solution doesn't depend on that upgrade and is a bit cleaner anyway.)

3 of 3 new or added lines in 1 file covered. (100.0%)

326 of 374 relevant lines covered (87.17%)

19.02 hits per line