1
93%
master: 93%

Ran 10 Jan 2022 06:36PM UTC

Files 55

Run time 9s

Badge

Embed ▾

Committed 10 Jan 2022 06:31PM UTC coverage: 89.602% (-0.07%) from 89.672%

Job # #691.1

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Better fix for crash on member selects inside module-info.java (#544)

Now, in `matchMemberSelectTree()`, we check if the `MemberSelectTree` represents a reference to a module.  If it does, we do not check if its base expression could be `null`.  This change gives us a stronger invariant in `mayBeNullExpr()`: any `IdentifierTree` or `MemberSelectTree` passed to `mayBeNullExpr()` should have a non-null symbol.  We explicitly check this to help us flag any future weird cases more easily.

Unfortunately, to maintain JDK 8 compatibility, the check for whether a `MemberSelectTree` represents a module requires reflection.  Testing did not reveal any significant performance impact.  If / when NullAway requires JDK 11, we can and should get rid of the reflection.

Code coverage is reduced due to the new runtime checks for (hopefully) impossible cases in `mayBeNullExpr()`.

Fixes #533

Run Details

4119 of 4597 relevant lines covered (89.6%)

0.9 hits per line

uber / NullAway / #691 / 1
93%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #691.1

uber / NullAway / #691 / 1 93% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #691.1

uber / NullAway / #691 / 1
93%
master: 93%

README BADGES
x