#691
93%

Ran 10 Jan 2022 06:36PM UTC

Jobs 1

Files 55

Run time 10s

Badge

Embed ▾

pending completion

Build # #691

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Better fix for crash on member selects inside module-info.java (#544)

Now, in `matchMemberSelectTree()`, we check if the `MemberSelectTree` represents a reference to a module.  If it does, we do not check if its base expression could be `null`.  This change gives us a stronger invariant in `mayBeNullExpr()`: any `IdentifierTree` or `MemberSelectTree` passed to `mayBeNullExpr()` should have a non-null symbol.  We explicitly check this to help us flag any future weird cases more easily.

Unfortunately, to maintain JDK 8 compatibility, the check for whether a `MemberSelectTree` represents a module requires reflection.  Testing did not reveal any significant performance impact.  If / when NullAway requires JDK 11, we can and should get rid of the reflection.

Code coverage is reduced due to the new runtime checks for (hopefully) impossible cases in `mayBeNullExpr()`.

Fixes #533

Run Details

4119 of 4597 relevant lines covered (89.6%)

0.9 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
57	93.75	-0.42%	../nullaway/src/main/java/com/uber/nullaway/NullAway.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#691.1	10 Jan 2022 06:36PM UTC	55	89.6

uber / NullAway / #691
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #691

uber / NullAway / #691 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #691

uber / NullAway / #691
93%

README BADGES
x