3
0%
main: 93%

Ran 17 Sep 2015 07:43PM UTC

Files 394

Run time 11s

Badge

Embed ▾

Committed 17 Sep 2015 07:35PM UTC coverage: 71.689% (+0.4%) from 71.336%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Don't modify globs excludes argument value.

Ideally, users shouldn't be using variables in BUILD files, but if they do, we shouldn't be modifying their values.

The error message that comes up is like this when the excludes value is reused as a sources list:

                       File ".../src/python/pants/base/target.py", line 545, in create_sources_field
                         assert_list(sources, key_arg=key_arg)
                       File ".../src/python/pants/base/validation.py", line 49, in assert_list
                         .format(key_msg, expected_type, e, e.__class__))
                     ValueError: In key 'sources': Expected a list containing values of type (<type 'basestring'>,), instead got a value ['fleem.java'] of <type 'list'>

Testing Done:
Wrote regression test, saw that it failed. Updated implementation and made it pass.

Bugs closed: 2213

Reviewed at https://rbcommons.com/s/twitter/r/2841/

Coverage Stats

16968 of 23669 relevant lines covered (71.69%)

0.72 hits per line

pantsbuild / pants / 6922 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6922.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6922 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6922.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6922 / 3
0%
main: 93%

README BADGES
x