3
0%
main: 93%

Ran 16 Sep 2015 12:11AM UTC

Files 392

Run time 2min

Badge

Embed ▾

Committed 15 Sep 2015 11:49PM UTC coverage: 70.928% (-0.04%) from 70.966%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Fix `linecount` estimator for `dep-usage` goal

In 8c82cf54, the `file_line_count` function was renamed to `line_count`, but
one of the occurrences was renamed to `linecount` by mistake.  This causes the
`dep-usage` goal to fail when provided with the `linecount` estimator.

This change adds a new unit test for the `dep-usage` goal which failed
before the change and succeeds after.

Testing Done:
$ ./pants test tests/python/pants_test/util:fileutil

Travis: https://travis-ci.org/pantsbuild/pants/builds/80541842

This was also identified by `pylint`.  After this I'm going to focus on getting larger project-wide pylint-checks to pass.

Bugs closed: 2203

Reviewed at https://rbcommons.com/s/twitter/r/2828/

Coverage Stats

16778 of 23655 relevant lines covered (70.93%)

0.71 hits per line

pantsbuild / pants / 6879 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6879.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6879 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6879.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6879 / 3
0%
main: 93%

README BADGES
x