3
0%
main: 93%

Ran 15 Sep 2015 05:53AM UTC

Files 391

Run time 103min

Badge

Embed ▾

Committed 15 Sep 2015 05:53AM UTC coverage: 71.049% (-0.6%) from 71.628%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

jsirois

Commit Message

Fix resource handling for the python backend.

Previously resource handling was broken in a few ways:
1. Resources targets in the same build file could not be addressed
   via `PythonTarget.resources` because relative_to was not passed to
   the build_graph.
2. Since resource targets were not modelled as dependencies, they
   could not be found via the `PythonTarget.resources` property since
   they never were loaded into the build graph.
3. SetupPy only honored resources set via the `PythonTarget`
   `resources` constructor parameter.

This change fixes resources to be modelled as dependencies like they
are for `JvmTarget`, solving 2 above, and fixes resources target
resolution to use `relative_to` solving 1 above.  `SetupPy` now reads
resources from the fixed `PythonTarget.resources` property and gathers
resource sources like it does for all other dependencies fixing 3
above.

All existing python targets are updated to use `target_resources`
instead of `resources` as dogfood and a unit test is added to ensure
both modes of expressing resources work.

Testing Done:
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/80315273

Bugs closed: 309, 1841, 2191

Reviewed at https://rbcommons.com/s/twitter/r/2817/

Run Details

16708 of 23516 relevant lines covered (71.05%)

0.71 hits per line

pantsbuild / pants / 6860 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6860.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6860 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6860.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6860 / 3
0%
main: 93%

README BADGES
x