13
51%
master: 47%

Ran 27 May 2021 02:58AM UTC

Files 0

Run time 0s

Badge

Embed ▾

Committed 19 Mar 2019 01:28PM UTC coverage: 0.0%. First build

Job # CONFIGURE_ARGS="--without-cr" EXTRA="libldap2-dev libnet-ldap-server-perl"

Build Type

push

travis-ci

Committed by

nevun

Commit Message

Fix pam_get_data stack overwrite by saving a heap pointer instead

The previous code was using a trick of saving the actual retval value
as the "pointer". The problem with that was when pam_get_data copied
it out it treated it as a void* which is 8 byte on 64 bit operating
system which meant it copied 8 byte to a 4 byte location and overwrote
the stack with 4 bytes.

The fix is using a heap pointer instead, influenced by the official
code in https://github.com/linux-pam/linux-pam/blob/master/modules/pam_unix/pam_unix_auth.c

With feedback from pedro martelletto, thanks.

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Yubico / yubico-pam / 354 / 13
51%
master: 47%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 354.13 (CONFIGURE_ARGS="--without-cr" EXTRA="libldap2-dev libnet-ldap-server-perl")

Yubico / yubico-pam / 354 / 13 51% master: 47%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 354.13 (CONFIGURE_ARGS="--without-cr" EXTRA="libldap2-dev libnet-ldap-server-perl")

Yubico / yubico-pam / 354 / 13
51%
master: 47%

README BADGES
x