354
51%
master: 47%

Ran 19 Mar 2019 01:40PM UTC

Jobs 3

Files 2

Run time 1151358min

Badge

Embed ▾

pending completion

Build # 354

Build Type

push

travis-ci

Committed by

nevun

Commit Message

Fix pam_get_data stack overwrite by saving a heap pointer instead

The previous code was using a trick of saving the actual retval value
as the "pointer". The problem with that was when pam_get_data copied
it out it treated it as a void* which is 8 byte on 64 bit operating
system which meant it copied 8 byte to a 4 byte location and overwrote
the stack with 4 bytes.

The fix is using a heap pointer instead, influenced by the official
code in https://github.com/linux-pam/linux-pam/blob/master/modules/pam_unix/pam_unix_auth.c

With feedback from pedro martelletto, thanks.

Run Details

405 of 788 relevant lines covered (51.4%)

15.38 hits per line

Jobs

ID	Job ID	Ran	Coverage
13	354.13 (CONFIGURE_ARGS="--without-cr" EXTRA="libldap2-dev libnet-ldap-server-perl")	27 May 2021 02:58AM UTC	0.0	Travis Job 354.13
14	354.14 (CONFIGURE_ARGS="--without-cr" EXTRA="libldap2-dev libnet-ldap-server-perl")	27 May 2021 02:59AM UTC	82.98	Travis Job 354.14
17	354.17 (COVERAGE="--enable-coverage" EXTRA="libldap2-dev libykpers-1-dev libnet-ldap-server-perl lcov")	19 Mar 2019 01:40PM UTC	51.4	Travis Job 354.17

Source Files on build 354

Detailed source file information is not available for this build.

Yubico / yubico-pam / 354
51%
master: 47%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 354

Yubico / yubico-pam / 354 51% master: 47%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 354

Yubico / yubico-pam / 354
51%
master: 47%

README BADGES
x