expertiza / expertiza / 11632 / 4
37%
main: 47%

LAST BUILD BRANCH: (HEAD detached at pull/2958/merge)
DEFAULT BRANCH: main
Ran
Files 288
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 11.577%. Remained the same
2.2.7, CC_TEST_REPORTER_ID=d20eadb9183f9f1866657be5b5e47b4a2398ff1ea0be29fbd50a26a43ea98b62 REPORT_REPO_NAME=Travis-ci-code-coverage-reports TOKEN=[secure] TESTFOLDER=helpers

push

travis-ci-com

web-flow 
E2102. Refactor quiz_questionnaires_controller.rb (#1899)

* Lines 23-24 contain useless comments; remove.

* Explain what a valid request is

* Change if not --> unless

* Clearer assignment quiz message

* Update quiz_questionnaires_controller_spec.rb:209 to new error message

Should also fix job 11084.3 in failed build

* use authorization helper methods in action allowed

* make better use of the authorization helper methods

* team_check --> team_valid? + simplifications

* include AuthorizationHelper

* Comment at line 52 is confusing. fix

* Line 55 needs a comment saying what it is doing. Fix

* I’m not clear on what a “choice” is; please explain. Fix

* Line 255: Not clear what a “choice type” is. fix

* Reword comment

* Line 146: Need an explanation (comment) about what a valid question is FIX

* Fix mixmatched comments

* Put create methods before update

* Replace the word question with item

As requested by the OSS project document

* Change comments on 45, 244

* explain why valid.eql? is needed

* Rename 'q' with 'questionChoice' for clarity

As requested

* refactor save_choices to use a question factory method

* remove colon in function definition because this is ruby, not python

Co-authored-by: Surya Makthal <42852918+suryamak@users.noreply.github.com>
Co-authored-by: Surya Makthal <smaktha@ncsu.edu>

1818 of 15703 relevant lines covered (11.58%)

1.53 hits per line

Source Files on job 11632.4 (2.2.7, CC_TEST_REPORTER_ID=d20eadb9183f9f1866657be5b5e47b4a2398ff1ea0be29fbd50a26a43ea98b62 REPORT_REPO_NAME=Travis-ci-code-coverage-reports TOKEN=[secure] TESTFOLDER=helpers)