11632
37%
main: 47%

Ran 19 May 2021 07:33PM UTC

Jobs 4

Files 288

Run time 12min

Badge

Embed ▾

pending completion

Build # 11632

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

E2102. Refactor quiz_questionnaires_controller.rb (#1899)

* Lines 23-24 contain useless comments; remove.

* Explain what a valid request is

* Change if not --> unless

* Clearer assignment quiz message

* Update quiz_questionnaires_controller_spec.rb:209 to new error message

Should also fix job 11084.3 in failed build

* use authorization helper methods in action allowed

* make better use of the authorization helper methods

* team_check --> team_valid? + simplifications

* include AuthorizationHelper

* Comment at line 52 is confusing. fix

* Line 55 needs a comment saying what it is doing. Fix

* I’m not clear on what a “choice” is; please explain. Fix

* Line 255: Not clear what a “choice type” is. fix

* Reword comment

* Line 146: Need an explanation (comment) about what a valid question is FIX

* Fix mixmatched comments

* Put create methods before update

* Replace the word question with item

As requested by the OSS project document

* Change comments on 45, 244

* explain why valid.eql? is needed

* Rename 'q' with 'questionChoice' for clarity

As requested

* refactor save_choices to use a question factory method

* remove colon in function definition because this is ruby, not python

Co-authored-by: Surya Makthal <42852918+suryamak@users.noreply.github.com>
Co-authored-by: Surya Makthal <smaktha@ncsu.edu>

Run Details

8577 of 13342 relevant lines covered (64.29%)

55.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	11632.1 (2.2.7, CC_TEST_REPORTER_ID=d20eadb9183f9f1866657be5b5e47b4a2398ff1ea0be29fbd50a26a43ea98b62 REPORT_REPO_NAME=Travis-ci-code-coverage-reports TOKEN=[secure] TESTFOLDER=features)	19 May 2021 07:42PM UTC	35.44	Travis Job 11632.1
2	11632.2 (2.2.7, CC_TEST_REPORTER_ID=d20eadb9183f9f1866657be5b5e47b4a2398ff1ea0be29fbd50a26a43ea98b62 REPORT_REPO_NAME=Travis-ci-code-coverage-reports TOKEN=[secure] TESTFOLDER=models)	19 May 2021 07:39PM UTC	29.68	Travis Job 11632.2
3	11632.3 (2.2.7, CC_TEST_REPORTER_ID=d20eadb9183f9f1866657be5b5e47b4a2398ff1ea0be29fbd50a26a43ea98b62 REPORT_REPO_NAME=Travis-ci-code-coverage-reports TOKEN=[secure] TESTFOLDER=controllers)	19 May 2021 07:35PM UTC	34.88	Travis Job 11632.3
4	11632.4 (2.2.7, CC_TEST_REPORTER_ID=d20eadb9183f9f1866657be5b5e47b4a2398ff1ea0be29fbd50a26a43ea98b62 REPORT_REPO_NAME=Travis-ci-code-coverage-reports TOKEN=[secure] TESTFOLDER=helpers)	19 May 2021 07:33PM UTC	11.58	Travis Job 11632.4

Source Files on build 11632

Detailed source file information is not available for this build.

expertiza / expertiza / 11632
37%
main: 47%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11632

expertiza / expertiza / 11632 37% main: 47%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11632

expertiza / expertiza / 11632
37%
main: 47%

README BADGES
x