pantsbuild / pants / 6544 / 3
0%
main: 93%

LAST BUILD BRANCH: add/remove-python-trampoline-overhead
DEFAULT BRANCH: main
Ran
Files 381
Run time 13s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 70.097%. Remained the same
CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

push

travis-ci

jsirois 
Ensure pipeline failuires fail CI.

We use pipelines to collect filtered lists of targets for
several CI steps.  Previously these could fail when BUILD
files had sytax or other errors, but the CI run would proceed
with no targets.  This change turns on pipefail and lifts up
target collection steps so they are AND'ed with the steps
that use them such that pipefail actually triggers an overall
failure in those steps.

Testing Done:
Manually tested by introducing 2 BUILD file errors:
```diff
$ git diff -U1 pants-plugins/
diff --git a/pants-plugins/tests/python/internal_backend_test/BUILD b/pants-plugins/tests/python/internal_backend_test/BUILD
index b9577ff..7b0e067 100644
--- a/pants-plugins/tests/python/internal_backend_test/BUILD
+++ b/pants-plugins/tests/python/internal_backend_test/BUILD
@@ -3,3 +3,3 @@

-target(
+target2(
   name='all',

$ git diff -U1 -- tests/python/
diff --git a/tests/python/pants_test/BUILD b/tests/python/pants_test/BUILD
index 3a3cc05..a710ed0 100644
--- a/tests/python/pants_test/BUILD
+++ b/tests/python/pants_test/BUILD
@@ -3,2 +3,4 @@

+GARBAGE
+
 python_library(
```

Then tested each pipeline-using CI step.

Internal plugins:
```console
$ ./build-support/bin/ci.sh -fkmsrjpnca
...
Exception message: name 'target2' is not defined
 while executing BUILD file FilesystemBuildFile(/home/jsirois/dev/3rdparty/jsirois-pants/pants-plugins/tests/python/internal_backend_test/BUILD)
 Loading addresses from 'pants-plugins/tests/python/internal_backend_test' failed.
Invalid BUILD files for [pants-plugins/tests/python::]

INFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants on branch jsirois/issues/2053

Internal backend python test failure
```

Python unit tests:
```console
$ ./build-support/bin/ci.sh -fkmsrjlnca
...
Exception message: name 'GARBAGE' is not defined
 while executing BUILD file FilesystemBuildFile(/home/jsirois/dev/3rdparty/jsirois-pants/tests/python/pants_test/BUILD)
 Loading addresses from 'tests/python/pants_test' failed.
Invalid BUILD files for [tests/python::]

INFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants on branch jsirois/issues/2053

Core python test failure
```

Python integration tests:
```console
$ ./build-support/bin/ci.sh -fkmsrjlpna
...
Exception message: name 'GARBAGE' is not defined
 while executing BUILD file FilesystemBuildFile(/home/jsirois/dev/3rdparty/jsirois-pants/tests/python/pants_test/BUILD)
 Loading addresses from 'tests/python/pants_test' failed.
Invalid BUILD files for [tests/python::]

INFO] Detected git repository at /home/jsirois/dev/3rdparty/jsirois-pants on branch jsirois/issues/2053

Pants Integration test failure
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/77969386

Bugs closed: 2053, 2096

Reviewed at https://rbcommons.com/s/twitter/r/2731/

15905 of 22690 relevant lines covered (70.1%)

0.7 hits per line

Source Files on job 6544.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")