pantsbuild / pants / 6527 / 2
0%
main: 93%

LAST BUILD BRANCH: csb/new-lockfile-ignore
DEFAULT BRANCH: main
Ran
Files 381
Run time 15s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 70.571%. Remained the same
CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'"

push

travis-ci

jsirois 
Initial support for `resolve.npm`.

This is pants implementing `npm install` for node projects modeled in
pants.  The driving concern is primary control by pants of Node.js
packages via BUILD files, and this necessitates generating package.json
files under `.pants.d/` to describe dependencies (and later more) to
`npm` so it can resolve both local and remote dependencies.  A second
fallout is copying pants controlled node module sourcecode up into
`.pants.d/` since `node` has a documented behavior of resolving against
`realpath`[1], foiling any attempt to use symlinks.

The basic targets needed to support `resolve.npm` - aka `npm install`
are added along with basic tests for the functionality.

[1] https://nodejs.org/api/modules.html#modules_addenda_package_manager_tips

Testing Done:
I manually confirmed that with the NpmResolve execution of `npm dedupe`
commented out, the dedupe portion of the
`NpmResolveTest.test_resolve_simple_graph` test failed like so:
```console
E     AssertionError: Expected to find exactly 1 de-duped `typ` package, but found these:
E     	node_modules/typ/package.json
E     	node_modules/util/node_modules/typ/package.json
```

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/77852199

Bugs closed: 2073, 2087

Reviewed at https://rbcommons.com/s/twitter/r/2723/

16007 of 22682 relevant lines covered (70.57%)

0.71 hits per line

Source Files on job 6527.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'")