pantsbuild / pants / 6506 / 3
0%
main: 93%

LAST BUILD BRANCH: jwb/log-workunit-duration
DEFAULT BRANCH: main
Ran
Files 381
Run time 15s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 70.589% (+0.01%) from 70.576%
CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

push

travis-ci

stuhood 
Populate classes_by_target using the context jar for the isolated strategy

- Remove the option to not jar classpath outputs in the isolated strategy
- Populate classes_by_target using the context jar
- Add a simplified `relpath` implementation, because it was showing up inordinately hot on profiles

This avoids a filesystem walk during the population of products. That means that we do one less filesystem walk when we hit the cache, or when we're populating products for an already built target.

Testing Done:
https://github.com/pantsbuild/pants/pull/2082

----

For a large classpath:
    $ find .pants.d/compile/jvm -name '*.class' | wc -l
      180463

Before:

    21:31:49 00:14         [apt-pre]
    21:31:49 00:14         [java-pre]
    21:31:49 00:14         [zinc-pre]
    21:31:51 00:16         [zinc-prepare]
    21:31:51 00:16           [validate-zinc-analysis]
    21:31:51 00:16           [isolation-zinc-pool-bootstrap]
    21:31:51 00:16         [apt-prepare]
    21:31:51 00:16           [validate-java-analysis]
    21:31:51 00:16           [isolation-java-pool-bootstrap]
    21:31:51 00:16         [zinc-execute]
    21:32:17 00:42         [apt-execute]
    21:32:17 00:42         [zinc-execute]
    21:32:25 00:50         [zinc-finalize]
    21:32:26 00:51         [apt-finalize]
    21:32:26 00:51         [apt-post]
    21:32:26 00:51         [java-post]
    21:32:26 00:51         [zinc-post]

After:

    23:26:01 00:13         [apt-pre]
    23:26:01 00:13         [java-pre]
    23:26:01 00:13         [zinc-pre]
    23:26:02 00:14         [apt-prepare]
    23:26:02 00:14           [validate-java-analysis]
    23:26:02 00:14           [isolation-java-pool-bootstrap]
    23:26:02 00:14         [zinc-prepare]
    23:26:02 00:14           [validate-zinc-analysis]
    23:26:03 00:15           [isolation-zinc-pool-bootstrap]
    23:26:03 00:15         [apt-execute]
    23:26:03 00:15         [zinc-execute]
    23:26:16 00:28         [apt-finalize]
    23:26:16 00:28         [zinc-finalize]
    23:26:16 00:28         [apt-post]
    23:26:16 00:28         [java-post]
    23:26:16 00:28         [zinc-post]

Reviewed at https://rbcommons.com/s/twitter/r/2720/

16006 of 22675 relevant lines covered (70.59%)

0.71 hits per line

Source Files on job 6506.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")