3
74%
main: 93%

Ran 24 Aug 2015 08:53PM UTC

Files 356

Run time 10s

Badge

Embed ▾

Committed 24 Aug 2015 08:24PM UTC coverage: 69.652% (+0.3%) from 69.366%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Add a just-in-time check of the artifact cache to the isolated compile strategy

Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.

In the future, pushing the invalidation check down into the `work` function that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.

- Add a double check of the cache to the isolated strategy immediately before beginning to compile.

Testing Done:
https://github.com/pantsbuild/pants/pull/2052

Reviewed at https://rbcommons.com/s/twitter/r/2690/

Coverage Stats

15079 of 21649 relevant lines covered (69.65%)

0.7 hits per line

pantsbuild / pants / 6386 / 3
74%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6386.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6386 / 3 74% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6386.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 6386 / 3
74%
main: 93%

README BADGES
x