3
61%
develop: 81%

Ran 10 Aug 2015 08:09PM CUT

Files 167

Run time 4s

Badge

Embed ▾

Committed 10 Aug 2015 08:00PM CUT coverage: 80.174% (+0.2%) from 79.935%

Job # 606.3

Build Type

push

travis-ci

Committed by jenkins

Commit Message

Remove injector and callbackConverter from Controller.

Problem:
Controller uses setter injection to populate the injector and callbackConverter.  Setter injection is confusing and difficult to reason about.

Solution:
Remove injector and callbackConverter fields from Controller and have them supplied by the HttpRouter provide them when it builds the routes.

Result:
Controller is simplier and easier to reason about.

RB_ID=727188

Run Details

1751 of 2184 relevant lines covered (80.17%)

0.8 hits per line

Source Files on job 606.3

Show entries

Search:

File	Lines	Relevant	Missed
.../finatra/http/filters/ExceptionBarrierFilter.scala	32	5	5
...r/finatra/http/modules/ResponseBuilderModule.scala	13	2	2
.../scala/finatra/quickstart/services/IdService.scala	16	3	3
.../finatra/httpclient/modules/HttpClientModule.scala	52	13	13
...om/twitter/finatra/httpclient/RichHttpClient.scala	29	6	6
...inatra/http/exceptions/HttpResponseException.scala	12	1	1
...a/finatra/quickstart/firebase/FirebaseClient.scala	35	7	7
...quickstart/modules/TwitterCloneJacksonModule.scala	7	1	1
...la/com/twitter/finatra/httpclient/HttpClient.scala	75	20	20
...t/app/internal/JodatimeDurationTypeConvertor.scala	13	2	2

Showing 1 to 10 of 167 entries

twitter / finatra / 606 / 3
61%
develop: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 606.3

twitter / finatra / 606 / 3 61% develop: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 606.3

twitter / finatra / 606 / 3
61%
develop: 81%

README BADGES
x