• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

twitter / finatra / 606
61%
develop: 81%

Build:
Build:
LAST BUILD BRANCH: master
DEFAULT BRANCH: develop
Ran 10 Aug 2015 08:09PM UTC
Jobs 6
Files 167
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
606

push

travis-ci

jenkins
Remove injector and callbackConverter from Controller.

Problem:
Controller uses setter injection to populate the injector and callbackConverter.  Setter injection is confusing and difficult to reason about.

Solution:
Remove injector and callbackConverter fields from Controller and have them supplied by the HttpRouter provide them when it builds the routes.

Result:
Controller is simplier and easier to reason about.

RB_ID=727188

8 of 8 new or added lines in 3 files covered. (100.0%)

1765 of 2184 relevant lines covered (80.82%)

4.82 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
jackson/src/main/scala/com/twitter/finatra/json/internal/caseclass/jackson/FinatraCaseClassDeserializer.scala
5
100.0
http/src/main/scala/com/twitter/finatra/http/response/ResponseBuilder.scala
Jobs
ID Job ID Ran Files Coverage
1 606.1 10 Aug 2015 08:11PM UTC 0
80.17
Travis Job 606.1
2 606.2 10 Aug 2015 08:13PM UTC 0
80.54
Travis Job 606.2
3 606.3 10 Aug 2015 08:09PM UTC 0
80.17
Travis Job 606.3
4 606.4 10 Aug 2015 08:11PM UTC 0
80.27
Travis Job 606.4
5 606.5 10 Aug 2015 08:11PM UTC 0
80.36
Travis Job 606.5
6 606.6 10 Aug 2015 08:10PM UTC 0
80.22
Travis Job 606.6
Source Files on build 606
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #606
  • b0492db5 on github
  • Prev Build on master (#602)
  • Next Build on master (#607)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc